From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrXTV-00078R-D8 for qemu-devel@nongnu.org; Fri, 13 Dec 2013 13:28:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrXTQ-0007JH-LW for qemu-devel@nongnu.org; Fri, 13 Dec 2013 13:28:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrXTQ-0007J3-CH for qemu-devel@nongnu.org; Fri, 13 Dec 2013 13:28:28 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDISR64006148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 13:28:27 -0500 Date: Fri, 13 Dec 2013 19:28:25 +0100 From: Kevin Wolf Message-ID: <20131213182825.GO3916@dhcp-200-207.str.redhat.com> References: <1385444708-19439-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1385444708-19439-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 0/6] block: allow commit active as top List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 26.11.2013 um 06:45 hat Fam Zheng geschrieben: > Previously live commit of active block device is not supported, this series > implements it and updates corresponding qemu-iotests cases. > > This series is based on BlockJobType enum QAPI series. > > v6: Address comments from Stefan: > > [04/06] commit: support commit active layer > Fix wording. > [05/06] qemu-iotests: update test cases for commit active > Drop is_active. > > Experimental for reviewers: the side by side diff against previous series: > > http://goo.gl/vgN6mc > > v5: Address comments from Eric and Paolo: > Add mirror_start_job and front end wrapper. [Paolo] > Base on BlockJobType enum in QAPI. [Eric] > Drop "common" sync mode. [Eric] > > v4: Rewrite to reuse block/mirror.c. > When committing the active layer, the job is internally a mirror job with > type name faked to "commit". > When the job completes, the BDSes are swapped, so the base image become > active and [top, base) dropped. > > Fam Zheng (6): > mirror: don't close target > mirror: move base to MirrorBlockJob > block: add commit_active_start() > commit: support commit active layer > qemu-iotests: update test cases for commit active > commit: remove unused check > > block/commit.c | 8 +---- > block/mirror.c | 77 +++++++++++++++++++++++++++++++++++++++-------- > blockdev.c | 9 ++++-- > include/block/block_int.h | 22 ++++++++++++-- > qapi-schema.json | 5 +-- > tests/qemu-iotests/040 | 74 ++++++++++++++++++++------------------------- > 6 files changed, 126 insertions(+), 69 deletions(-) Patches 1-3 and 6 are: Reviewed-by: Kevin Wolf Patch 4 needs a fix, patch 5 didn't apply any more and needs a rebase. Kevin