From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46879)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrXwH-000771-Rs
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 13:58:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrXw7-0007n3-4c
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 13:58:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:9286)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrXw6-0007mt-SI
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 13:58:07 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDIw50k002900
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 13 Dec 2013 13:58:06 -0500
Date: Fri, 13 Dec 2013 19:58:03 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131213185803.GP3916@dhcp-200-207.str.redhat.com>
References: <1386954633-28905-1-git-send-email-mreitz@redhat.com>
	<1386954633-28905-6-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1386954633-28905-6-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from
	qdict_flatten_qdict()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
> delete is always set to true, therefore it can be removed.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Nope, this can't be right.

delete is always set, except for simple types in the top-level QDict.
They get deleted now instead of being left alone.

But it coincides pretty well with the new loop condition. Leaving
uninteresting stuff aside, the loop looks now like this:

    while (entry != NULL) {
        ...
        entry = qdict_first(qdict);
    }

So the loop only terminates when all elements have been removed. How
lucky we are that it really does remove all elements now!


Perhaps some other code is broken, or I missed something else, but
qemu-iotests 067 segfaults after this patch.

Kevin