From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrXyd-0001f4-Is
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 14:00:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrXyX-0008Tz-AV
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 14:00:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11012)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrXyX-0008Tf-2f
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 14:00:37 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDJ0Z3Q009352
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 13 Dec 2013 14:00:35 -0500
Date: Fri, 13 Dec 2013 20:00:31 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131213190006.GR3916@dhcp-200-207.str.redhat.com>
References: <1386954633-28905-1-git-send-email-mreitz@redhat.com>
	<1386954633-28905-3-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1386954633-28905-3-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 02/22] blkdebug: Don't require
	sophisticated filename
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
> If the filename is not prefixed by "blkdebug:" in
> blkdebug_parse_filename(), the blkdebug driver was not selected through
> that protocol prefix, but by an explicit command line option
> (file.driver=blkdebug or something similar). Contrary to the current
> reaction, this is not a problem at all; we just need to store the
> filename (in the x-image option) and can go on; the user just has to
> manually specify the config option.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

x-image must die, but why not, as an intermediate step.

Reviewed-by: Kevin Wolf <kwolf@redhat.com>