From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZFI-000783-SU for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:22:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrZFA-0007bA-Sn for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:22:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZFA-0007ae-Ib for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:21:52 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDKLpp9011248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 15:21:51 -0500 Date: Fri, 13 Dec 2013 21:21:49 +0100 From: Kevin Wolf Message-ID: <20131213202149.GA3916@dhcp-200-207.str.redhat.com> References: <1386954633-28905-1-git-send-email-mreitz@redhat.com> <1386954633-28905-14-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1386954633-28905-14-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 13/22] qemu-iotests: Fix output of test 051 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Allowing nested file formats now results in e.g. qcow2 BlockDriverStates > never being directly passed to bdrv_open_common() from bdrv_file_open(), > but instead being handed through bdrv_open(). This changes the error > message when trying to give a filename to qcow2, i.e. trying to use it > as a driver for the protocol level. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/051.out | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out > index 49e95a2..121ca66 100644 > --- a/tests/qemu-iotests/051.out > +++ b/tests/qemu-iotests/051.out > @@ -223,7 +223,7 @@ QEMU X.Y.Z monitor - type 'help' for more information > (qemu) q=1B[K=1B[Dqu=1B[K=1B[D=1B[Dqui=1B[K=1B[D=1B[D=1B[Dquit=1B[K > =20 > Testing: -drive file=3DTEST_DIR/t.qcow2,file.driver=3Dqcow2 > -QEMU_PROG: -drive file=3DTEST_DIR/t.qcow2,file.driver=3Dqcow2: could not= open disk image TEST_DIR/t.qcow2: Can't use 'qcow2' as a block driver for = the protocol level > +QEMU_PROG: -drive file=3DTEST_DIR/t.qcow2,file.driver=3Dqcow2: could not= open disk image TEST_DIR/t.qcow2: Block format 'qcow2' used by device '' d= oesn't support the option 'filename' Shows that our error messages aren't really good yet. bdrv_file_open() shouldn't be talking about device names, it's the wrong layer. But that's an unrelated problem. Reviewed-by: Kevin Wolf