On Fri, Dec 13, 2013 at 02:18:42PM -0600, Kwok, WingMan wrote: > > > -----Original Message----- > > From: Balbi, Felipe > > Sent: Friday, December 13, 2013 2:55 PM > > To: Kwok, WingMan > > Cc: Shilimkar, Santosh; Balbi, Felipe; Linux USB Mailing List; > > kgene.kim@samsung.com; Linux ARM Kernel Mailing List; linux-samsung- > > soc@vger.kernel.org; Linux OMAP Mailing List > > Subject: Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM support > > > > On Fri, Dec 13, 2013 at 10:04:38AM -0600, Kwok, WingMan wrote: > > > Hello > > > > > > > -----Original Message----- > > > > From: Shilimkar, Santosh > > > > Sent: Thursday, December 12, 2013 7:29 PM > > > > To: Balbi, Felipe > > > > Cc: Linux USB Mailing List; kgene.kim@samsung.com; Linux ARM Kernel > > > > Mailing List; linux-samsung-soc@vger.kernel.org; Linux OMAP Mailing > > > > List; Kwok, WingMan > > > > Subject: Re: [PATCH v2 1/7] usb: dwc3: keystone: add basic PM > > > > support > > > > > > > > On Thursday 12 December 2013 04:45 PM, Felipe Balbi wrote: > > > > > A bare-minimum PM implementation which will server as building > > > > > block for more complex > > > > s/server/serve ;-) > > > > > PM implementation in the future. > > > > > > > > > > At the least will not leave clocks on unnecessarily when e.g. a > > > > > user write mem to /sys/power/state. > > > > > > > > > > Signed-off-by: Felipe Balbi > > > > > --- > > > > > > > > > > improve error path a little bit. > > > > > > > > > We will test this out. Thanks for the patch Felipe. > > > > > > > > > > I have tested the patch and the keystone usb driver continues to > > > function, though I can't test suspend at this time as the rest of the > > > system does not that functionality yet. > > > > Thanks, should I add your Tested-by ? > > Yes please. you need to reply with Tested-by: Your Name just to make it all official. Sorry -- balbi