From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZLA-0001Tr-OL for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:28:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrZL4-0001RP-Os for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:28:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrZL4-0001RL-Gw for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:27:58 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDKRvlv017269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Dec 2013 15:27:57 -0500 Date: Fri, 13 Dec 2013 21:27:55 +0100 From: Kevin Wolf Message-ID: <20131213202755.GB3916@dhcp-200-207.str.redhat.com> References: <1386954633-28905-1-git-send-email-mreitz@redhat.com> <1386954633-28905-15-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386954633-28905-15-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 14/22] blockdev: Move "file" to legacy_opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi Am 13.12.2013 um 18:10 hat Max Reitz geschrieben: > Specifying the image filename through the "file" option is a legacy > option and should not be supported by blockdev-add (in that case, giving > a string for "file" references an existing block device). > > Signed-off-by: Max Reitz This is a good one, I've been meaning to do this for a while. One thing that is left in blockdev_init() and should be removed eventually is the handling of 'no medium'. But it's unrelated and I'm not sure yet how to do it right. Reviewed-by: Kevin Wolf