From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrZl0-0004jk-0f
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:54:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrZks-0000i2-Vy
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:54:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29867)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VrZks-0000hx-N4
	for qemu-devel@nongnu.org; Fri, 13 Dec 2013 15:54:38 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBDKsb5D032635
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 13 Dec 2013 15:54:37 -0500
Date: Fri, 13 Dec 2013 21:54:34 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131213205434.GH3916@dhcp-200-207.str.redhat.com>
References: <1386954633-28905-1-git-send-email-mreitz@redhat.com>
	<1386954633-28905-21-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1386954633-28905-21-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug
	and blkverify
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
> Add structures to support blkdebug and blkverify in blockdev-add.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qapi-schema.json | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 90 insertions(+), 4 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index c3c939c..6ce016c 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4166,6 +4166,94 @@
>              '*pass-discard-other': 'bool' } }
>  
>  ##
> +# @BlkdebugInjectErrorOptions
> +#
> +# Describes a single error injection for blkdebug.
> +#
> +# @event:       trigger event name
> +#
> +# @state:       #optional the state identifier blkdebug needs to be in to
> +#               actually trigger the event; defaults to "any"
> +#
> +# @error:       #optional error identifier (errno) to be returned; defaults to
> +#               EIO
> +#
> +# @sector:      #optional specifies the sector index which has to be affected
> +#               in order to actually trigger the event; defaults to "any
> +#               sector"
> +#
> +# @once:        #optional disables further events after this one has been
> +#               triggered; defaults to false
> +#
> +# @immediately: #optional fail immediately; defaults to false
> +#
> +# Since: 2.0
> +##
> +{ 'type': 'BlkdebugInjectErrorOptions',
> +  'data': { 'event': 'str',

I bet Eric will tell you that an enum for event would be much nicer. ;-)

Reviewed-by: Kevin Wolf <kwolf@redhat.com>