* [patch] pinctrl: off by one in msm_config_group_set()
@ 2013-12-16 10:42 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-12-16 10:42 UTC (permalink / raw)
To: Linus Walleij, Bjorn Andersson; +Cc: linux-kernel, kernel-janitors
This should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".
Fixes: f365be092572 ('pinctrl: Add Qualcomm TLMM driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c
index 28b90aba708d..03c4e615ebb8 100644
--- a/drivers/pinctrl/pinctrl-msm.c
+++ b/drivers/pinctrl/pinctrl-msm.c
@@ -350,7 +350,7 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
break;
case PIN_CONFIG_DRIVE_STRENGTH:
/* Check for invalid values */
- if (arg > ARRAY_SIZE(msm_drive_to_regval))
+ if (arg >= ARRAY_SIZE(msm_drive_to_regval))
arg = -1;
else
arg = msm_drive_to_regval[arg];
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] pinctrl: off by one in msm_config_group_set()
@ 2013-12-16 10:42 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-12-16 10:42 UTC (permalink / raw)
To: Linus Walleij, Bjorn Andersson; +Cc: linux-kernel, kernel-janitors
This should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".
Fixes: f365be092572 ('pinctrl: Add Qualcomm TLMM driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c
index 28b90aba708d..03c4e615ebb8 100644
--- a/drivers/pinctrl/pinctrl-msm.c
+++ b/drivers/pinctrl/pinctrl-msm.c
@@ -350,7 +350,7 @@ static int msm_config_group_set(struct pinctrl_dev *pctldev,
break;
case PIN_CONFIG_DRIVE_STRENGTH:
/* Check for invalid values */
- if (arg > ARRAY_SIZE(msm_drive_to_regval))
+ if (arg >= ARRAY_SIZE(msm_drive_to_regval))
arg = -1;
else
arg = msm_drive_to_regval[arg];
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] pinctrl: off by one in msm_config_group_set()
2013-12-16 10:42 ` Dan Carpenter
@ 2013-12-20 9:31 ` Linus Walleij
-1 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-12-20 9:31 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Bjorn Andersson, linux-kernel, kernel-janitors
On Mon, Dec 16, 2013 at 11:42 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> This should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".
>
> Fixes: f365be092572 ('pinctrl: Add Qualcomm TLMM driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This appears to be fixed already by one of Björn's follow-up
patches, so dropping this patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] pinctrl: off by one in msm_config_group_set()
@ 2013-12-20 9:31 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-12-20 9:31 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Bjorn Andersson, linux-kernel, kernel-janitors
On Mon, Dec 16, 2013 at 11:42 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> This should be ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".
>
> Fixes: f365be092572 ('pinctrl: Add Qualcomm TLMM driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This appears to be fixed already by one of Björn's follow-up
patches, so dropping this patch.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-20 9:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-16 10:42 [patch] pinctrl: off by one in msm_config_group_set() Dan Carpenter
2013-12-16 10:42 ` Dan Carpenter
2013-12-20 9:31 ` Linus Walleij
2013-12-20 9:31 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.