From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401Ab3LPKtb (ORCPT ); Mon, 16 Dec 2013 05:49:31 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:54384 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006Ab3LPKt3 (ORCPT ); Mon, 16 Dec 2013 05:49:29 -0500 Date: Mon, 16 Dec 2013 11:49:27 +0100 From: Ludovic Desroches To: Russell King - ARM Linux CC: , , , , , Ludovic Desroches Subject: Re: possible regression on 3.13 when calling flush_dcache_page Message-ID: <20131216104927.GA9627@ldesroches-Latitude-E6320> Mail-Followup-To: Russell King - ARM Linux , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iamjoonsoo.kim@lge.com References: <20131212143149.GI12099@ldesroches-Latitude-E6320> <20131212171322.GT4360@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20131212171322.GT4360@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2013 at 05:13:22PM +0000, Russell King - ARM Linux wrote: > On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > > I'll investigate on atmel-mci driver side but if someone has also this > > issue or see what is wrong in the driver, please tell me all about it. > > I'm not entirely sure what's causing this, but calling flush_dcache_page() > from an IRQ isn't the best idea, as one of its side effects will be to > unmask IRQs at the CPU. > Thans for pointing this point. Having a look to other mmc drivers, it seems flush_dcache_page() is also called from an IRQ. Not sure that deferring it is the way to go. What should be the most proper solution? > BTW, the faulting function seems to have been removed in more recent > kernels. Same error with rc4 and linux-next. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic Desroches Subject: Re: possible regression on 3.13 when calling flush_dcache_page Date: Mon, 16 Dec 2013 11:49:27 +0100 Message-ID: <20131216104927.GA9627@ldesroches-Latitude-E6320> References: <20131212143149.GI12099@ldesroches-Latitude-E6320> <20131212171322.GT4360@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20131212171322.GT4360@n2100.arm.linux.org.uk> Sender: owner-linux-mm@kvack.org To: Russell King - ARM Linux Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iamjoonsoo.kim@lge.com, Ludovic Desroches List-Id: linux-mmc@vger.kernel.org On Thu, Dec 12, 2013 at 05:13:22PM +0000, Russell King - ARM Linux wrote: > On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > > I'll investigate on atmel-mci driver side but if someone has also this > > issue or see what is wrong in the driver, please tell me all about it. > > I'm not entirely sure what's causing this, but calling flush_dcache_page() > from an IRQ isn't the best idea, as one of its side effects will be to > unmask IRQs at the CPU. > Thans for pointing this point. Having a look to other mmc drivers, it seems flush_dcache_page() is also called from an IRQ. Not sure that deferring it is the way to go. What should be the most proper solution? > BTW, the faulting function seems to have been removed in more recent > kernels. Same error with rc4 and linux-next. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches@atmel.com (Ludovic Desroches) Date: Mon, 16 Dec 2013 11:49:27 +0100 Subject: possible regression on 3.13 when calling flush_dcache_page In-Reply-To: <20131212171322.GT4360@n2100.arm.linux.org.uk> References: <20131212143149.GI12099@ldesroches-Latitude-E6320> <20131212171322.GT4360@n2100.arm.linux.org.uk> Message-ID: <20131216104927.GA9627@ldesroches-Latitude-E6320> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Dec 12, 2013 at 05:13:22PM +0000, Russell King - ARM Linux wrote: > On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > > I'll investigate on atmel-mci driver side but if someone has also this > > issue or see what is wrong in the driver, please tell me all about it. > > I'm not entirely sure what's causing this, but calling flush_dcache_page() > from an IRQ isn't the best idea, as one of its side effects will be to > unmask IRQs at the CPU. > Thans for pointing this point. Having a look to other mmc drivers, it seems flush_dcache_page() is also called from an IRQ. Not sure that deferring it is the way to go. What should be the most proper solution? > BTW, the faulting function seems to have been removed in more recent > kernels. Same error with rc4 and linux-next.