All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drivers: tty: Mark the functions as static in n_gsm.c
@ 2013-12-16 10:58 Rashika Kheria
  2013-12-16 11:01   ` Rashika Kheria
  2013-12-16 11:10 ` [PATCH 1/2] drivers: tty: Mark the functions as static in n_gsm.c Josh Triplett
  0 siblings, 2 replies; 6+ messages in thread
From: Rashika Kheria @ 2013-12-16 10:58 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg Kroah-Hartman, Jiri Slaby, josh

Marks the functions gsm_cleanup_mux(), gsm_activate_mux(),
gsm_free_mux(), gsm_alloc_mux() and gsm_change_mtu() as static in
n_gsm.c because they are not used outside this file.

Also, drop the EXPORT_SYMBOL_GPL for the above mentioned functions
because nothing else in the kernel calls them.

This eliminates the following warnings in n_gsm.c:
drivers/tty/n_gsm.c:2022:6: warning: no previous prototype for ‘gsm_cleanup_mux’ [-Wmissing-prototypes]
drivers/tty/n_gsm.c:2076:5: warning: no previous prototype for ‘gsm_activate_mux’ [-Wmissing-prototypes]
drivers/tty/n_gsm.c:2120:6: warning: no previous prototype for ‘gsm_free_mux’ [-Wmissing-prototypes]
drivers/tty/n_gsm.c:2156:17: warning: no previous prototype for ‘gsm_alloc_mux’ [-Wmissing-prototypes]
drivers/tty/n_gsm.c:2714:5: warning: no previous prototype for ‘gsm_change_mtu’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/tty/n_gsm.c |   14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index c0f76da..6ca9fbb 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -2019,7 +2019,7 @@ static void gsm_error(struct gsm_mux *gsm,
  *	and then shut down each device hanging up the channels as we go.
  */
 
-void gsm_cleanup_mux(struct gsm_mux *gsm)
+static void gsm_cleanup_mux(struct gsm_mux *gsm)
 {
 	int i;
 	struct gsm_dlci *dlci = gsm->dlci[0];
@@ -2062,7 +2062,6 @@ void gsm_cleanup_mux(struct gsm_mux *gsm)
 		kfree(txq);
 	INIT_LIST_HEAD(&gsm->tx_list);
 }
-EXPORT_SYMBOL_GPL(gsm_cleanup_mux);
 
 /**
  *	gsm_activate_mux	-	generic GSM setup
@@ -2073,7 +2072,7 @@ EXPORT_SYMBOL_GPL(gsm_cleanup_mux);
  *	finally kick off connecting to DLCI 0 on the modem.
  */
 
-int gsm_activate_mux(struct gsm_mux *gsm)
+static int gsm_activate_mux(struct gsm_mux *gsm)
 {
 	struct gsm_dlci *dlci;
 	int i = 0;
@@ -2109,7 +2108,6 @@ int gsm_activate_mux(struct gsm_mux *gsm)
 	gsm->dead = 0;		/* Tty opens are now permissible */
 	return 0;
 }
-EXPORT_SYMBOL_GPL(gsm_activate_mux);
 
 /**
  *	gsm_free_mux		-	free up a mux
@@ -2117,13 +2115,12 @@ EXPORT_SYMBOL_GPL(gsm_activate_mux);
  *
  *	Dispose of allocated resources for a dead mux
  */
-void gsm_free_mux(struct gsm_mux *gsm)
+static void gsm_free_mux(struct gsm_mux *gsm)
 {
 	kfree(gsm->txframe);
 	kfree(gsm->buf);
 	kfree(gsm);
 }
-EXPORT_SYMBOL_GPL(gsm_free_mux);
 
 /**
  *	gsm_free_muxr		-	free up a mux
@@ -2153,7 +2150,7 @@ static inline void mux_put(struct gsm_mux *gsm)
  *	Creates a new mux ready for activation.
  */
 
-struct gsm_mux *gsm_alloc_mux(void)
+static struct gsm_mux *gsm_alloc_mux(void)
 {
 	struct gsm_mux *gsm = kzalloc(sizeof(struct gsm_mux), GFP_KERNEL);
 	if (gsm == NULL)
@@ -2185,7 +2182,6 @@ struct gsm_mux *gsm_alloc_mux(void)
 
 	return gsm;
 }
-EXPORT_SYMBOL_GPL(gsm_alloc_mux);
 
 /**
  *	gsmld_output		-	write to link
@@ -2711,7 +2707,7 @@ static void gsm_mux_rx_netchar(struct gsm_dlci *dlci,
 	return;
 }
 
-int gsm_change_mtu(struct net_device *net, int new_mtu)
+static int gsm_change_mtu(struct net_device *net, int new_mtu)
 {
 	struct gsm_mux_net *mux_net = (struct gsm_mux_net *)netdev_priv(net);
 	if ((new_mtu < 8) || (new_mtu > mux_net->dlci->gsm->mtu))
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c
  2013-12-16 10:58 [PATCH 1/2] drivers: tty: Mark the functions as static in n_gsm.c Rashika Kheria
@ 2013-12-16 11:01   ` Rashika Kheria
  2013-12-16 11:10 ` [PATCH 1/2] drivers: tty: Mark the functions as static in n_gsm.c Josh Triplett
  1 sibling, 0 replies; 6+ messages in thread
From: Rashika Kheria @ 2013-12-16 11:01 UTC (permalink / raw)
  To: linux-kernel
  Cc: Greg Kroah-Hartman, Jiri Slaby, Rashika Kheria,
	Hendrik Brueckner, linuxppc-dev, josh

Mark the function hvc_poll_init() as static in hvc/hvc_console.c because
it is not used outside this file.

This eliminates the following warning in hvc/hvc_console.c:
drivers/tty/hvc/hvc_console.c:791:5: warning: no previous prototype for ‘hvc_poll_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/tty/hvc/hvc_console.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 9eba119..50b4688 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -788,7 +788,7 @@ static int hvc_tiocmset(struct tty_struct *tty,
 }
 
 #ifdef CONFIG_CONSOLE_POLL
-int hvc_poll_init(struct tty_driver *driver, int line, char *options)
+static int hvc_poll_init(struct tty_driver *driver, int line, char *options)
 {
 	return 0;
 }
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c
@ 2013-12-16 11:01   ` Rashika Kheria
  0 siblings, 0 replies; 6+ messages in thread
From: Rashika Kheria @ 2013-12-16 11:01 UTC (permalink / raw)
  To: linux-kernel
  Cc: Greg Kroah-Hartman, linuxppc-dev, josh, Rashika Kheria,
	Hendrik Brueckner, Jiri Slaby

Mark the function hvc_poll_init() as static in hvc/hvc_console.c because
it is not used outside this file.

This eliminates the following warning in hvc/hvc_console.c:
drivers/tty/hvc/hvc_console.c:791:5: warning: no previous prototype for ‘hvc_poll_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
 drivers/tty/hvc/hvc_console.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 9eba119..50b4688 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -788,7 +788,7 @@ static int hvc_tiocmset(struct tty_struct *tty,
 }
 
 #ifdef CONFIG_CONSOLE_POLL
-int hvc_poll_init(struct tty_driver *driver, int line, char *options)
+static int hvc_poll_init(struct tty_driver *driver, int line, char *options)
 {
 	return 0;
 }
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drivers: tty: Mark the functions as static in n_gsm.c
  2013-12-16 10:58 [PATCH 1/2] drivers: tty: Mark the functions as static in n_gsm.c Rashika Kheria
  2013-12-16 11:01   ` Rashika Kheria
@ 2013-12-16 11:10 ` Josh Triplett
  1 sibling, 0 replies; 6+ messages in thread
From: Josh Triplett @ 2013-12-16 11:10 UTC (permalink / raw)
  To: Rashika Kheria; +Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby

On Mon, Dec 16, 2013 at 04:28:24PM +0530, Rashika Kheria wrote:
> Marks the functions gsm_cleanup_mux(), gsm_activate_mux(),
> gsm_free_mux(), gsm_alloc_mux() and gsm_change_mtu() as static in
> n_gsm.c because they are not used outside this file.
> 
> Also, drop the EXPORT_SYMBOL_GPL for the above mentioned functions
> because nothing else in the kernel calls them.
> 
> This eliminates the following warnings in n_gsm.c:
> drivers/tty/n_gsm.c:2022:6: warning: no previous prototype for ‘gsm_cleanup_mux’ [-Wmissing-prototypes]
> drivers/tty/n_gsm.c:2076:5: warning: no previous prototype for ‘gsm_activate_mux’ [-Wmissing-prototypes]
> drivers/tty/n_gsm.c:2120:6: warning: no previous prototype for ‘gsm_free_mux’ [-Wmissing-prototypes]
> drivers/tty/n_gsm.c:2156:17: warning: no previous prototype for ‘gsm_alloc_mux’ [-Wmissing-prototypes]
> drivers/tty/n_gsm.c:2714:5: warning: no previous prototype for ‘gsm_change_mtu’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/tty/n_gsm.c |   14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index c0f76da..6ca9fbb 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -2019,7 +2019,7 @@ static void gsm_error(struct gsm_mux *gsm,
>   *	and then shut down each device hanging up the channels as we go.
>   */
>  
> -void gsm_cleanup_mux(struct gsm_mux *gsm)
> +static void gsm_cleanup_mux(struct gsm_mux *gsm)
>  {
>  	int i;
>  	struct gsm_dlci *dlci = gsm->dlci[0];
> @@ -2062,7 +2062,6 @@ void gsm_cleanup_mux(struct gsm_mux *gsm)
>  		kfree(txq);
>  	INIT_LIST_HEAD(&gsm->tx_list);
>  }
> -EXPORT_SYMBOL_GPL(gsm_cleanup_mux);
>  
>  /**
>   *	gsm_activate_mux	-	generic GSM setup
> @@ -2073,7 +2072,7 @@ EXPORT_SYMBOL_GPL(gsm_cleanup_mux);
>   *	finally kick off connecting to DLCI 0 on the modem.
>   */
>  
> -int gsm_activate_mux(struct gsm_mux *gsm)
> +static int gsm_activate_mux(struct gsm_mux *gsm)
>  {
>  	struct gsm_dlci *dlci;
>  	int i = 0;
> @@ -2109,7 +2108,6 @@ int gsm_activate_mux(struct gsm_mux *gsm)
>  	gsm->dead = 0;		/* Tty opens are now permissible */
>  	return 0;
>  }
> -EXPORT_SYMBOL_GPL(gsm_activate_mux);
>  
>  /**
>   *	gsm_free_mux		-	free up a mux
> @@ -2117,13 +2115,12 @@ EXPORT_SYMBOL_GPL(gsm_activate_mux);
>   *
>   *	Dispose of allocated resources for a dead mux
>   */
> -void gsm_free_mux(struct gsm_mux *gsm)
> +static void gsm_free_mux(struct gsm_mux *gsm)
>  {
>  	kfree(gsm->txframe);
>  	kfree(gsm->buf);
>  	kfree(gsm);
>  }
> -EXPORT_SYMBOL_GPL(gsm_free_mux);
>  
>  /**
>   *	gsm_free_muxr		-	free up a mux
> @@ -2153,7 +2150,7 @@ static inline void mux_put(struct gsm_mux *gsm)
>   *	Creates a new mux ready for activation.
>   */
>  
> -struct gsm_mux *gsm_alloc_mux(void)
> +static struct gsm_mux *gsm_alloc_mux(void)
>  {
>  	struct gsm_mux *gsm = kzalloc(sizeof(struct gsm_mux), GFP_KERNEL);
>  	if (gsm == NULL)
> @@ -2185,7 +2182,6 @@ struct gsm_mux *gsm_alloc_mux(void)
>  
>  	return gsm;
>  }
> -EXPORT_SYMBOL_GPL(gsm_alloc_mux);
>  
>  /**
>   *	gsmld_output		-	write to link
> @@ -2711,7 +2707,7 @@ static void gsm_mux_rx_netchar(struct gsm_dlci *dlci,
>  	return;
>  }
>  
> -int gsm_change_mtu(struct net_device *net, int new_mtu)
> +static int gsm_change_mtu(struct net_device *net, int new_mtu)
>  {
>  	struct gsm_mux_net *mux_net = (struct gsm_mux_net *)netdev_priv(net);
>  	if ((new_mtu < 8) || (new_mtu > mux_net->dlci->gsm->mtu))
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c
  2013-12-16 11:01   ` Rashika Kheria
@ 2013-12-16 11:11     ` Josh Triplett
  -1 siblings, 0 replies; 6+ messages in thread
From: Josh Triplett @ 2013-12-16 11:11 UTC (permalink / raw)
  To: Rashika Kheria
  Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby, Hendrik Brueckner,
	linuxppc-dev

On Mon, Dec 16, 2013 at 04:31:28PM +0530, Rashika Kheria wrote:
> Mark the function hvc_poll_init() as static in hvc/hvc_console.c because
> it is not used outside this file.
> 
> This eliminates the following warning in hvc/hvc_console.c:
> drivers/tty/hvc/hvc_console.c:791:5: warning: no previous prototype for ‘hvc_poll_init’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/tty/hvc/hvc_console.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
> index 9eba119..50b4688 100644
> --- a/drivers/tty/hvc/hvc_console.c
> +++ b/drivers/tty/hvc/hvc_console.c
> @@ -788,7 +788,7 @@ static int hvc_tiocmset(struct tty_struct *tty,
>  }
>  
>  #ifdef CONFIG_CONSOLE_POLL
> -int hvc_poll_init(struct tty_driver *driver, int line, char *options)
> +static int hvc_poll_init(struct tty_driver *driver, int line, char *options)
>  {
>  	return 0;
>  }
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c
@ 2013-12-16 11:11     ` Josh Triplett
  0 siblings, 0 replies; 6+ messages in thread
From: Josh Triplett @ 2013-12-16 11:11 UTC (permalink / raw)
  To: Rashika Kheria
  Cc: Greg Kroah-Hartman, Hendrik Brueckner, Jiri Slaby, linux-kernel,
	linuxppc-dev

On Mon, Dec 16, 2013 at 04:31:28PM +0530, Rashika Kheria wrote:
> Mark the function hvc_poll_init() as static in hvc/hvc_console.c becaus=
e
> it is not used outside this file.
>=20
> This eliminates the following warning in hvc/hvc_console.c:
> drivers/tty/hvc/hvc_console.c:791:5: warning: no previous prototype for=
 =E2=80=98hvc_poll_init=E2=80=99 [-Wmissing-prototypes]
>=20
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  drivers/tty/hvc/hvc_console.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_consol=
e.c
> index 9eba119..50b4688 100644
> --- a/drivers/tty/hvc/hvc_console.c
> +++ b/drivers/tty/hvc/hvc_console.c
> @@ -788,7 +788,7 @@ static int hvc_tiocmset(struct tty_struct *tty,
>  }
> =20
>  #ifdef CONFIG_CONSOLE_POLL
> -int hvc_poll_init(struct tty_driver *driver, int line, char *options)
> +static int hvc_poll_init(struct tty_driver *driver, int line, char *op=
tions)
>  {
>  	return 0;
>  }
> --=20
> 1.7.9.5
>=20

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-16 11:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-16 10:58 [PATCH 1/2] drivers: tty: Mark the functions as static in n_gsm.c Rashika Kheria
2013-12-16 11:01 ` [PATCH 2/2] drivers: tty: Mark the function hvc_poll_init() as static in hvc_console.c Rashika Kheria
2013-12-16 11:01   ` Rashika Kheria
2013-12-16 11:11   ` Josh Triplett
2013-12-16 11:11     ` Josh Triplett
2013-12-16 11:10 ` [PATCH 1/2] drivers: tty: Mark the functions as static in n_gsm.c Josh Triplett

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.