From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/irq: simplify irq checks in drm_wait_vblank Date: Mon, 16 Dec 2013 12:18:08 +0100 Message-ID: <20131216111807.GC15379@ulmo.nvidia.com> References: <1386758111-3446-30-git-send-email-daniel.vetter@ffwll.ch> <1387189813-3677-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1568847663==" Return-path: Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) by gabe.freedesktop.org (Postfix) with ESMTP id C2CB1FA2A3 for ; Mon, 16 Dec 2013 03:19:31 -0800 (PST) Received: by mail-bk0-f53.google.com with SMTP id na10so2266037bkb.12 for ; Mon, 16 Dec 2013 03:19:30 -0800 (PST) In-Reply-To: <1387189813-3677-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org --===============1568847663== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V88s5gaDVPzZ0KCq" Content-Disposition: inline --V88s5gaDVPzZ0KCq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 16, 2013 at 11:30:13AM +0100, Daniel Vetter wrote: > Checking for both an irq number _and_ whether it's enabled is > redundant. Originally I've thought the drm_dev_to_irq call would break > drivers which do their own irq checking, but those shouldn't have > DRIVER_HAVE_IRQ set as Thierry Reding pointed out. But such drivers > already need to set dev->irq_enabled for other reasons, so we might as > well ditch that check, too. >=20 > v2: Also drop the HAVE_IRQ check. >=20 > Cc: Thierry Reding > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_irq.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Thierry Reding --V88s5gaDVPzZ0KCq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJSruFvAAoJEN0jrNd/PrOhYZ8QALPqkX2QAU/u5sZjGkL4Qm4b mkT5NbFJ5Bx6KFNJLFGdmXHXHZMbT6pwkuQmO8TGnTZm8V32Fo7iN8F4tdfyPTRQ weQCAizsOpOWweA9oRjnmbWEutezHMfWHkNmBgpuogzpEPc5AgIeNqebUnnYdF5I K1e5JJ2Ro8MwrJMeHXHGSvANQCt8UKRnuZu9nyE3xTxS13m1SMDVhqVPiX33XI1k ppfppAgSLQhlcpanB/JXRs7SA+SLS46/tb9vQE2mjKc7ZIvoSG+5lsu/ii5zgQa1 iVqKTkGfeCLkEk2frjK9AhDxSkAqrWMIjrZd0/mu1ns8AEXmXmQ8CY7JqjXLI3WJ /fFdXvqssqJejMlKkHuQ74az3ylbkoXZoaBiOk66tehJXB9hQwdhvCRxhaL+T5cX P3OO3bWmacxgC80Frv0onGKZ6C0cdBPW4fMeRFIMWCCacTFbTxKodOfYwTNfH81u hFlqss484uemkA+Q6Z24+LugLfAkMgr2miwy0LawTsnOYyqiBLnudmJQ7yh6FC+G 1QdUuuo1CwMnUBkjzxwfQWPFGYo6PnzkGqIFVBKnisqV+0YbQs+Uty8gZbfS/RWv pFsRtGhddGj+NQ0I++nVhhrqec86SYsKSBWJsYGwwq4jQfdJuWtzyENHD/hzw497 aHqNF7Uf5IUL6apisG+d =UFjG -----END PGP SIGNATURE----- --V88s5gaDVPzZ0KCq-- --===============1568847663== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1568847663==--