From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 6/6] drm/i915: inform drm_fb_helper if we abandoned a connected output Date: Mon, 16 Dec 2013 16:18:53 -0800 Message-ID: <20131216161853.2b388fef@jbarnes-desktop> References: <1386880917-2951-1-git-send-email-jbarnes@virtuousgeek.org> <1386880917-2951-6-git-send-email-jbarnes@virtuousgeek.org> <20131212223041.GC1403@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from alt-proxy17.mail.unifiedlayer.com (alt-proxy17.mail.unifiedlayer.com [66.147.241.60]) by gabe.freedesktop.org (Postfix) with SMTP id 26D0AFA3E8 for ; Mon, 16 Dec 2013 16:17:04 -0800 (PST) In-Reply-To: <20131212223041.GC1403@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 12 Dec 2013 22:30:41 +0000 Chris Wilson wrote: > On Thu, Dec 12, 2013 at 12:41:57PM -0800, Jesse Barnes wrote: > > Otherwise subsequent fb activity will try to do blank/unblank on outputs > > that were never fully enabled. > > Hmm, actually this highlights a bug in drm_setup_crtcs() that we do not > reconstruct enabled[] after a return false here. > > Only the first enabled[i] = false is required where we continue rather > than abort. Fixed, thanks. -- Jesse Barnes, Intel Open Source Technology Center