From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46493)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VsfpQ-0007gZ-82
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 16:35:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VsfpI-00080G-Kx
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 16:35:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14548)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1VsfpH-000804-Sv
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 16:35:44 -0500
Date: Mon, 16 Dec 2013 16:33:09 -0500
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20131216163309.6ce584b6@redhat.com>
In-Reply-To: <1386786254-5640-1-git-send-email-jjherne@us.ibm.com>
References: <1386786254-5640-1-git-send-email-jjherne@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] [PATCH RFC v4] qemu-monitor: HMP cpu-add
	wrapper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Jason J. Herne" <jjherne@us.ibm.com>
Cc: qemu-devel@nongnu.org

On Wed, 11 Dec 2013 13:24:14 -0500
"Jason J. Herne" <jjherne@us.ibm.com> wrote:

> From: "Jason J. Herne" <jjherne@us.ibm.com>
> 
> Add HMP cpu-add wrapper to allow cpu hot plugging via monitor.
> 
> Signed-off-by: Jason J. Herne <jjherne@us.ibm.com>

Applied to the qmp branch, thanks.

> ---
>  hmp-commands.hx | 13 +++++++++++++
>  hmp.c           | 10 ++++++++++
>  hmp.h           |  1 +
>  3 files changed, 24 insertions(+)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index caae5ad..028a8a1 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1620,6 +1620,19 @@ Executes a qemu-io command on the given block device.
>  ETEXI
>  
>      {
> +        .name       = "cpu-add",
> +        .args_type  = "id:i",
> +        .params     = "id",
> +        .help       = "add cpu",
> +        .mhandler.cmd  = hmp_cpu_add,
> +    },
> +
> +STEXI
> +@item cpu-add @var{id}
> +Add CPU with id @var{id}
> +ETEXI
> +
> +    {
>          .name       = "info",
>          .args_type  = "item:s?",
>          .params     = "[subcommand]",
> diff --git a/hmp.c b/hmp.c
> index 32ee285..c513f9b 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1525,6 +1525,16 @@ void hmp_nbd_server_stop(Monitor *mon, const QDict *qdict)
>      hmp_handle_error(mon, &errp);
>  }
>  
> +void hmp_cpu_add(Monitor *mon, const QDict *qdict)
> +{
> +    int cpuid;
> +    Error *err = NULL;
> +
> +    cpuid = qdict_get_int(qdict, "id");
> +    qmp_cpu_add(cpuid, &err);
> +    hmp_handle_error(mon, &err);
> +}
> +
>  void hmp_chardev_add(Monitor *mon, const QDict *qdict)
>  {
>      const char *args = qdict_get_str(qdict, "args");
> diff --git a/hmp.h b/hmp.h
> index 54cf71f..f92fc89 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -89,5 +89,6 @@ void hmp_nbd_server_stop(Monitor *mon, const QDict *qdict);
>  void hmp_chardev_add(Monitor *mon, const QDict *qdict);
>  void hmp_chardev_remove(Monitor *mon, const QDict *qdict);
>  void hmp_qemu_io(Monitor *mon, const QDict *qdict);
> +void hmp_cpu_add(Monitor *mon, const QDict *qdict);
>  
>  #endif