From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsgCf-0000mu-Qf for qemu-devel@nongnu.org; Mon, 16 Dec 2013 16:59:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsgCZ-0006YS-Ow for qemu-devel@nongnu.org; Mon, 16 Dec 2013 16:59:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsgCZ-0006YM-Gh for qemu-devel@nongnu.org; Mon, 16 Dec 2013 16:59:47 -0500 Date: Mon, 16 Dec 2013 22:59:18 +0100 From: Igor Mammedov Message-ID: <20131216225918.0ddc1dd1@thinkpad> In-Reply-To: <52AF744E.2070704@redhat.com> References: <1386951736-929-1-git-send-email-imammedo@redhat.com> <1386951736-929-10-git-send-email-imammedo@redhat.com> <20131216193014.GC21330@redhat.com> <20131216213819.48568028@thinkpad> <52AF744E.2070704@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/11] ACPI: move PRST OperationRegion into SSDT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: aliguori@amazon.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, hutao@cn.fujitsu.com, jjherne@us.ibm.com, brogers@suse.com, kraxel@redhat.com, stefanha@redhat.com, kaneshige.kenji@jp.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, pbonzini@redhat.com On Mon, 16 Dec 2013 22:44:46 +0100 Laszlo Ersek wrote: > On 12/16/13 21:38, Igor Mammedov wrote: > > On Mon, 16 Dec 2013 21:30:14 +0200 > > "Michael S. Tsirkin" wrote: > > > >> On Fri, Dec 13, 2013 at 05:22:14PM +0100, Igor Mammedov wrote: > >>> .. and report range used by it to OSPM via _CRS. > >>> PRST is needed in SSDT since its base will depend on > >>> chipset and will be dynamically set by QEMU. > >>> Also move PRSC() method along with PRST since cross > >>> table reference to PRST doesn't work. > >> > >> Could you clarify this last sentence? > >> I don't mind where it is but I'd like to know > >> where does the limitation come from. > > It's empiric deduction so far I haven't found such limitation in spec yet. > > iasl builds tables just fine but neither linux nor windows were able to find > > Operation region from SSDT when loading DSDT, failing whole table loading > > process. Decompiling DSDT/SSDT tables in guest shows that region is in > > expected scope but OSPM refuses to see it when referenced outside SSDT. > > Maybe there is some AML magic to make it work, I'm not aware of. > > The same thing I had to do for memory hotplug as well. So I've tried to play > > nicely 2 times and I have ended up with this solution both times. > > Would this work? > > diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > index 995b415..34fad66 100644 > --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl > +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > @@ -52,8 +52,8 @@ Scope(\_SB) { > Sleep(200) > } > > - OperationRegion(PRST, SystemIO, 0xaf00, 32) > - Field(PRST, ByteAcc, NoLock, Preserve) { > + External(\_SB.CPHD.PRST, OpRegionObj) > + Field(\_SB.CPHD.PRST, ByteAcc, NoLock, Preserve) { that was my first patch attempt :) You have to be careful and touch [q35-]acpi-dsdt.dsl since make doesn't handle deps to acpi-dsdt-cpu-hotplug.dsl correctly. After that RHEL6 guest fails to load ACPI tables. > PRS, 256 > } > Method(PRSC, 0) { > diff --git a/hw/i386/ssdt-misc.dsl b/hw/i386/ssdt-misc.dsl > index a4484b8..b831fc3 100644 > --- a/hw/i386/ssdt-misc.dsl > +++ b/hw/i386/ssdt-misc.dsl > @@ -116,4 +116,29 @@ DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1) > } > } > } > + Scope(\_SB) { > + Device(CPHD) { > + Name(_HID, EISAID("PNP0C08")) > + Name(CPPL, 32) // cpu-gpe length > + Name(CPHP, 0xaf00) > + > + OperationRegion(PRST, SystemIO, CPHP, CPPL) > + > + /* Leave bit 0 cleared to avoid Windows BSOD */ > + Name(_STA, 0xA) > + > + Method(_CRS, 0) { > + Store(ResourceTemplate() { > + IO(Decode16, 0x00, 0x00, 0x01, 0x15, IO) > + }, Local0) > + > + CreateWordField(Local0, IO._MIN, IOMN) > + CreateWordField(Local0, IO._MAX, IOMX) > + > + Store(CPHP, IOMN) > + Subtract(Add(CPHP, CPPL), 1, IOMX) > + Return(Local0) > + } > + } // Device(CPHD) > + } // Scope(\_SB) > } > > Thanks > Laszlo > -- Regards, Igor