From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799Ab3LQTkI (ORCPT ); Tue, 17 Dec 2013 14:40:08 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:48377 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746Ab3LQTkE (ORCPT ); Tue, 17 Dec 2013 14:40:04 -0500 Date: Tue, 17 Dec 2013 14:40:02 -0500 (EST) Message-Id: <20131217.144002.1716319550180883592.davem@davemloft.net> To: nicolas.dichtel@6wind.com Cc: netdev@vger.kernel.org, gregkh@linuxfoundation.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, williams@redhat.com, linux-rt-users@vger.kernel.org, lclaudio@uudg.org Subject: Re: [PATCH linux-3.10.y] ip6tnl: fix use after free of fb_tnl_dev From: David Miller In-Reply-To: <1386925595-4995-1-git-send-email-nicolas.dichtel@6wind.com> References: <20131212.153545.1184197791301496227.davem@davemloft.net> <1386925595-4995-1-git-send-email-nicolas.dichtel@6wind.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.1 (shards.monkeyblade.net [0.0.0.0]); Tue, 17 Dec 2013 11:40:03 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolas Dichtel Date: Fri, 13 Dec 2013 10:06:35 +0100 > The upstream commit bb8140947a24 ("ip6tnl: allow to use rtnl ops on fb tunnel") > (backported into linux-3.10.y) left a bug which was fixed upstream by commit > 1e9f3d6f1c40 ("ip6tnl: fix use after free of fb_tnl_dev"). > > The problem is a bit different in linux-3.10.y, because there is no x-netns > support (upstream commit 0bd8762824e7 ("ip6tnl: add x-netns support")). > When ip6_tunnel.ko is unloaded, FB device is deleted by rtnl_link_unregister() > and then we try to delete it again in ip6_tnl_destroy_tunnels(). > > This patch removes the second deletion. > > Reported-by: Steven Rostedt > Suggested-by: Steven Rostedt > Signed-off-by: Nicolas Dichtel Greg please queue this up for 3.10 -stable if you haven't already. Thanks a lot.