All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org,
	dm-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
	swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org,
	leedom-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
	santosh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
	kumaras-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
	nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH net 0/9] Fixes for server entries and server filter entries for Chelsio T4/T5
Date: Tue, 17 Dec 2013 16:29:33 -0500 (EST)	[thread overview]
Message-ID: <20131217.162933.204709940918878458.davem@davemloft.net> (raw)
In-Reply-To: <1387195938-3531-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>

From: Hariprasad Shenai <hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
Date: Mon, 16 Dec 2013 17:42:09 +0530

> This patch series provides miscelleneous fixes for Chelsio T4/T5 adapters
> related to server entries and server filter entries.

You add the sftids_in_use counter, but it is never tested by any code.
It is only initialized to zero, incremented, and decremented.  It
serves no real purpose at all.

Please don't add things like this.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2013-12-17 21:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 12:12 [PATCH net 0/9] Fixes for server entries and server filter entries for Chelsio T4/T5 Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 1/9] cxgb4: Properly account for server filter entries Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 2/9] cxgb4: Reserve stid 0 for T4/T5 adapters Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 3/9] cxgb4: Include TCP as protocol when creating server filters Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 4/9] cxgb4: Account for stid entries properly in case of IPv6 Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 5/9] cxgb4: Assign filter server TIDs properly Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 6/9] cxgb4: Add API to correctly calculate tuple fields Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 7/9] RDMA/cxgb4: Calculate the filter server TID properly Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 8/9] RDMA/cxgb4: Server filters are supported only for IPv4 Hariprasad Shenai
2013-12-16 12:12 ` [PATCH net 9/9] RDMA/cxgb4: Use cxgb4_select_ntuple to correctly calculate ntuple fields Hariprasad Shenai
     [not found] ` <1387195938-3531-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2013-12-17 21:29   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217.162933.204709940918878458.davem@davemloft.net \
    --to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
    --cc=dm-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
    --cc=hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
    --cc=kumaras-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
    --cc=leedom-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
    --cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
    --cc=santosh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.