From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VshOj-0007Df-K7 for qemu-devel@nongnu.org; Mon, 16 Dec 2013 18:16:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VshOd-0002uc-Kj for qemu-devel@nongnu.org; Mon, 16 Dec 2013 18:16:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VshOd-0002tE-Cl for qemu-devel@nongnu.org; Mon, 16 Dec 2013 18:16:19 -0500 Date: Tue, 17 Dec 2013 00:13:39 +0100 From: Igor Mammedov Message-ID: <20131217001339.36a03832@thinkpad> In-Reply-To: <52AF7D40.4080407@redhat.com> References: <1386951736-929-1-git-send-email-imammedo@redhat.com> <1386951736-929-10-git-send-email-imammedo@redhat.com> <20131216193014.GC21330@redhat.com> <20131216213819.48568028@thinkpad> <52AF744E.2070704@redhat.com> <20131216225918.0ddc1dd1@thinkpad> <52AF7D40.4080407@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/11] ACPI: move PRST OperationRegion into SSDT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: stefanha@redhat.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, hutao@cn.fujitsu.com, jjherne@us.ibm.com, brogers@suse.com, kraxel@redhat.com, aliguori@amazon.com, kaneshige.kenji@jp.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, pbonzini@redhat.com On Mon, 16 Dec 2013 23:22:56 +0100 Laszlo Ersek wrote: > On 12/16/13 22:59, Igor Mammedov wrote: > > On Mon, 16 Dec 2013 22:44:46 +0100 > > Laszlo Ersek wrote: > > > >> On 12/16/13 21:38, Igor Mammedov wrote: > >>> On Mon, 16 Dec 2013 21:30:14 +0200 > >>> "Michael S. Tsirkin" wrote: > >>> > >>>> On Fri, Dec 13, 2013 at 05:22:14PM +0100, Igor Mammedov wrote: > >>>>> .. and report range used by it to OSPM via _CRS. > >>>>> PRST is needed in SSDT since its base will depend on > >>>>> chipset and will be dynamically set by QEMU. > >>>>> Also move PRSC() method along with PRST since cross > >>>>> table reference to PRST doesn't work. > >>>> > >>>> Could you clarify this last sentence? > >>>> I don't mind where it is but I'd like to know > >>>> where does the limitation come from. > >>> It's empiric deduction so far I haven't found such limitation in spec yet. > >>> iasl builds tables just fine but neither linux nor windows were able to find > >>> Operation region from SSDT when loading DSDT, failing whole table loading > >>> process. Decompiling DSDT/SSDT tables in guest shows that region is in > >>> expected scope but OSPM refuses to see it when referenced outside SSDT. > >>> Maybe there is some AML magic to make it work, I'm not aware of. > >>> The same thing I had to do for memory hotplug as well. So I've tried to play > >>> nicely 2 times and I have ended up with this solution both times. > >> > >> Would this work? > >> > >> diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > >> index 995b415..34fad66 100644 > >> --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl > >> +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > >> @@ -52,8 +52,8 @@ Scope(\_SB) { > >> Sleep(200) > >> } > >> > >> - OperationRegion(PRST, SystemIO, 0xaf00, 32) > >> - Field(PRST, ByteAcc, NoLock, Preserve) { > >> + External(\_SB.CPHD.PRST, OpRegionObj) > >> + Field(\_SB.CPHD.PRST, ByteAcc, NoLock, Preserve) { > > that was my first patch attempt :) > > You have to be careful and touch [q35-]acpi-dsdt.dsl since make doesn't > > handle deps to acpi-dsdt-cpu-hotplug.dsl correctly. > > Yeah I think I noticed from the "make" output :) I grepped it for this > file's name. > > > After that RHEL6 guest fails to load ACPI tables. > > Could even be an ACPICA problem... Maybe it's iasl issue or linux&windows implementation is wrong (unlikely). > > Thanks! > Laszlo > > -- Regards, Igor