From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/5] drm/i915/bdw: Add support for DRRS to switch RR Date: Tue, 17 Dec 2013 12:30:00 +0000 Message-ID: <20131217123000.GJ22448@nuc-i3427.alporthouse.com> References: <1387258107-19232-1-git-send-email-vandana.kannan@intel.com> <1387258107-19232-6-git-send-email-vandana.kannan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id EB4DCFC644 for ; Tue, 17 Dec 2013 04:30:03 -0800 (PST) Content-Disposition: inline In-Reply-To: <1387258107-19232-6-git-send-email-vandana.kannan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Vandana Kannan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Dec 17, 2013 at 10:58:27AM +0530, Vandana Kannan wrote: > For Broadwell, there is one instance of Transcoder MN values per transcoder. > For dynamic switching between multiple refreshr rates, M/N values may be > reprogrammed on the fly. Link N programming triggers update of all data and > link M & N registers and the new M/N values will be used in the next frame > that is output. > > Signed-off-by: Vandana Kannan > Signed-off-by: Pradeep Bhat > --- > drivers/gpu/drm/i915/intel_dp.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 209be3c..183cfd7 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -798,9 +798,15 @@ intel_dp_set_m2_n2(struct intel_crtc *crtc, struct intel_link_m_n *m_n) > struct drm_i915_private *dev_priv = dev->dev_private; > enum transcoder transcoder = crtc->config.cpu_transcoder; > > - if (INTEL_INFO(dev)->gen >= 5 && INTEL_INFO(dev)->gen < 8) { > + if (INTEL_INFO(dev)->gen >= 8) { > + I915_WRITE(PIPE_DATA_M1(transcoder), > + TU_SIZE(m_n->tu) | m_n->gmch_m); > + I915_WRITE(PIPE_DATA_N1(transcoder), m_n->gmch_n); > + I915_WRITE(PIPE_LINK_M1(transcoder), m_n->link_m); > + I915_WRITE(PIPE_LINK_N1(transcoder), m_n->link_n); > + } else if (INTEL_INFO(dev)->gen >= 5 && INTEL_INFO(dev)->gen < 8) { Ouch. Double ouch later. -Chris -- Chris Wilson, Intel Open Source Technology Centre