Re: [RFC PATCH 00/10] Xen VMware tools support

From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Don Slutz <dslutz@verizon.com>
Cc: Keir Fraser <keir@xen.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Eddie Dong <eddie.dong@intel.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [RFC PATCH 00/10] Xen VMware tools support
Date: Tue, 17 Dec 2013 14:03:37 -0500	[thread overview]
Message-ID: <20131217190337.GA25371@phenom.dumpdata.com> (raw)
In-Reply-To: <1386875718-28166-1-git-send-email-dslutz@terremark.com>

On Thu, Dec 12, 2013 at 02:15:08PM -0500, Don Slutz wrote:
> From: Don Slutz <dslutz@verizon.com>
> 
> See
> 
> http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1009458

Can you say how this benefits Xen to detect this and take
advantage of it? Or is this Xen emulating VMWare so to a guest
it looks like its running under VMWare?

Thank you.
> 
> for info on detecting VMware.
> 
> Linux does not follow this exactly.  It checks for CPUID 1st.  If
> that fails, it checks for SMBIOS containing "VMware" (not VMware- or
> VMW).
> 
> So this patch set provides:
> 
>         SMBIOS -- Add string VMware-
>         CPUID -- Add VMware's CPUID (Note: currently HyperV (viridian support) breaks this check.)
>         Add the magic VMware port
>             Allow VMware tools poweroff and reboot
>             Enable access to VMware's guest info
>             Provide the VMware tools build number
> 
> Don Slutz (10):
>   smbios: Add "plus VMware-Tools" to HVM_XS_SYSTEM_PRODUCT_NAME.
>   Add VMware HVM params
>   Add cpuid_vmware_leaves
>   tools: Add support for new HVM params
>   vmport: Add VMware provided include files.
>   Add vmport structs
>   Add new vmport code.
>   connect vmport up
>   libxl: Add VTPOWER, VTREBOOT and VTPING
>   Add VMware guest info access
> 
>  tools/firmware/hvmloader/smbios.c        |   2 +-
>  tools/libxc/xc_domain.c                  | 112 +++++
>  tools/libxc/xc_domain_restore.c          |  27 ++
>  tools/libxc/xc_domain_save.c             |  24 ++
>  tools/libxc/xenctrl.h                    |  24 ++
>  tools/libxc/xg_save_restore.h            |   2 +
>  tools/libxl/libxl.c                      |  12 +
>  tools/libxl/libxl_create.c               |   4 +-
>  tools/libxl/libxl_dom.c                  |   5 +
>  tools/libxl/libxl_types.idl              |   5 +
>  tools/libxl/xl_cmdimpl.c                 |  10 +
>  tools/libxl/xl_cmdtable.c                |   2 +-
>  tools/libxl/xl_sxp.c                     |   4 +
>  xen/arch/x86/domctl.c                    |  34 ++
>  xen/arch/x86/hvm/Makefile                |   1 +
>  xen/arch/x86/hvm/hvm.c                   | 209 ++++++++-
>  xen/arch/x86/hvm/io.c                    |   4 +
>  xen/arch/x86/hvm/svm/svm.c               | 104 +++++
>  xen/arch/x86/hvm/svm/vmcb.c              |   1 +
>  xen/arch/x86/hvm/vmport/Makefile         |   1 +
>  xen/arch/x86/hvm/vmport/backdoor_def.h   | 167 +++++++
>  xen/arch/x86/hvm/vmport/guest_msg_def.h  |  87 ++++
>  xen/arch/x86/hvm/vmport/includeCheck.h   |  17 +
>  xen/arch/x86/hvm/vmport/vmport.c         | 719 +++++++++++++++++++++++++++++++
>  xen/arch/x86/hvm/vmport/xen_vmport_def.h |  36 ++
>  xen/arch/x86/hvm/vmx/vmcs.c              |   1 +
>  xen/arch/x86/hvm/vmx/vmx.c               | 125 ++++++
>  xen/arch/x86/hvm/vmx/vvmx.c              |  13 +
>  xen/arch/x86/traps.c                     |  58 ++-
>  xen/include/asm-x86/hvm/domain.h         |   4 +
>  xen/include/asm-x86/hvm/hvm.h            |   3 +
>  xen/include/asm-x86/hvm/trace.h          |   3 +
>  xen/include/asm-x86/hvm/vmport.h         |  77 ++++
>  xen/include/asm-x86/processor.h          |   2 +
>  xen/include/public/domctl.h              |   3 +
>  xen/include/public/hvm/hvm_op.h          |  18 +
>  xen/include/public/hvm/params.h          |  11 +-
>  xen/include/public/trace.h               |   1 +
>  38 files changed, 1926 insertions(+), 6 deletions(-)
>  create mode 100644 xen/arch/x86/hvm/vmport/Makefile
>  create mode 100644 xen/arch/x86/hvm/vmport/backdoor_def.h
>  create mode 100644 xen/arch/x86/hvm/vmport/guest_msg_def.h
>  create mode 100644 xen/arch/x86/hvm/vmport/includeCheck.h
>  create mode 100644 xen/arch/x86/hvm/vmport/vmport.c
>  create mode 100644 xen/arch/x86/hvm/vmport/xen_vmport_def.h
>  create mode 100644 xen/include/asm-x86/hvm/vmport.h
> 
> -- 
> 1.8.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel