From: Tim Deegan <tim@xen.org>
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: jun.nakajima@intel.com, Xen-devel@lists.xensource.com,
Ian Campbell <Ian.Campbell@citrix.com>,
george.dunlap@eu.citrix.com,
Julien Grall <julien.grall@linaro.org>,
eddie.dong@intel.com, keir.xen@gmail.com,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [V6 PATCH 6.2/7] pvh dom0: Add and remove foreign pages
Date: Wed, 18 Dec 2013 10:53:01 +0100 [thread overview]
Message-ID: <20131218095301.GA24792@deinos.phlegethon.org> (raw)
In-Reply-To: <20131217183426.11c79527@mantra.us.oracle.com>
At 18:34 -0800 on 17 Dec (1387301666), Mukesh Rathor wrote:
> On Tue, 17 Dec 2013 11:10:46 +0100
> Tim Deegan <tim@xen.org> wrote:
>
> > At 15:27 -0800 on 16 Dec (1387204042), Mukesh Rathor wrote:
> > > On Mon, 16 Dec 2013 08:40:41 +0000
> > > "Jan Beulich" <JBeulich@suse.com> wrote:
> > >
> > > > >>> On 14.12.13 at 03:48, Mukesh Rathor <mukesh.rathor@oracle.com>
> > > > >>> wrote:
> > > > >> Also, Jan may have an opinion about whether a teardown
> > > > >> operation that has to walk each p2m entry would have to be made
> > > > >> preemptible. I'm not sure where we draw the line on such
> > > > >> things.
> > > > >
> > > > > Since at present teardown cleanup of foreign is not really that
> > > > > important as its only applicable to dom0, let me submit another
> > > > > patch for it on Mon with few ideas. That would also keep this
> > > > > patch size reasonable, and keep you from having to look at the
> > > > > same code over and over.
> > > > >
> > > > > So, please take a look at the version below with above two
> > > > > fixes. If you approve it, i can resubmit the entire series
> > > > > rebased to latest with your ack on Monday, and the series can
> > > > > go in while we resolve the p2m teardown.
> > > >
> > > > Going through the patch again, I'm not seeing any loop being
> > > > added. Am I missing something here?
> > >
> > > Yes. Since the destruction of p2m leaking foreign pages only applies
> > > to control domain being destroyed, i don't think it is that critical
> > > that part get into 4.4.
> >
> > Nak. We can't let the tools break the refcounting.
>
> BTW, it appears that currently this cleanup doesn't happen on PV. If on a
> PV control domain and the tool stack has mapped foreign pages, and the
> PV control domain dies, the refcnt will be messed up. Right?
Not at all. PV domains' foreign mappings are refcounted through their
pagetables, which are unwound on domain destruction -- otherwise even
their local mappings would mess up the refcounts!
Tim.
next prev parent reply other threads:[~2013-12-18 9:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 2:38 [V6 PATCH 0/7]: PVH dom0 Mukesh Rathor
2013-12-06 2:38 ` [V6 PATCH 1/7] pvh dom0: move some pv specific code to static functions Mukesh Rathor
2013-12-06 2:38 ` [V6 PATCH 2/7] pvh dom0: construct_dom0 changes Mukesh Rathor
2013-12-06 2:38 ` [V6 PATCH 3/7] pvh dom0: implement XENMEM_add_to_physmap_range for x86 Mukesh Rathor
2013-12-06 2:38 ` [V6 PATCH 4/7] pvh dom0: Introduce p2m_map_foreign Mukesh Rathor
2013-12-09 12:02 ` Tim Deegan
2013-12-06 2:38 ` [V6 PATCH 5/7] pvh: change xsm_add_to_physmap Mukesh Rathor
2013-12-06 2:38 ` [V6 PATCH 6/7] pvh dom0: Add and remove foreign pages Mukesh Rathor
2013-12-06 2:54 ` Mukesh Rathor
2013-12-06 11:46 ` Jan Beulich
2013-12-07 2:09 ` Mukesh Rathor
2013-12-07 2:34 ` [V6 PATCH 6.1/7] " Mukesh Rathor
2013-12-07 16:06 ` Julien Grall
2013-12-09 9:50 ` Jan Beulich
2013-12-10 1:30 ` Mukesh Rathor
2013-12-09 10:31 ` Ian Campbell
2013-12-09 13:46 ` Julien Grall
2013-12-09 12:11 ` Tim Deegan
2013-12-10 2:16 ` Mukesh Rathor
2013-12-09 2:45 ` [V6 PATCH 6/7] " Julien Grall
2013-12-09 2:57 ` Julien Grall
2013-12-10 2:17 ` Mukesh Rathor
2013-12-11 0:27 ` [V6 PATCH 6.2/7] " Mukesh Rathor
2013-12-11 0:44 ` Mukesh Rathor
2013-12-11 1:35 ` Julien Grall
2013-12-11 1:47 ` Mukesh Rathor
2013-12-11 9:23 ` Jan Beulich
2013-12-11 14:29 ` Tim Deegan
2013-12-12 2:46 ` Mukesh Rathor
2013-12-13 2:44 ` Mukesh Rathor
2013-12-13 11:25 ` Tim Deegan
2013-12-13 11:39 ` Jan Beulich
2013-12-13 19:02 ` George Dunlap
2013-12-16 7:47 ` Jan Beulich
2013-12-14 2:48 ` Mukesh Rathor
2013-12-16 8:40 ` Jan Beulich
2013-12-16 23:27 ` Mukesh Rathor
2013-12-16 23:44 ` Julien Grall
2013-12-17 1:51 ` Mukesh Rathor
2013-12-17 2:33 ` Mukesh Rathor
2013-12-17 10:10 ` Tim Deegan
2013-12-17 23:24 ` Mukesh Rathor
2013-12-18 2:34 ` Mukesh Rathor
2013-12-18 9:51 ` Jan Beulich
2013-12-18 9:53 ` Tim Deegan [this message]
2013-12-06 2:38 ` [V6 PATCH 7/7] pvh dom0: add opt_dom0pvh to setup.c Mukesh Rathor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218095301.GA24792@deinos.phlegethon.org \
--to=tim@xen.org \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=Xen-devel@lists.xensource.com \
--cc=eddie.dong@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=julien.grall@linaro.org \
--cc=jun.nakajima@intel.com \
--cc=keir.xen@gmail.com \
--cc=mukesh.rathor@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.