From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756636Ab3LSXwG (ORCPT ); Thu, 19 Dec 2013 18:52:06 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:36813 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755875Ab3LSXwD (ORCPT ); Thu, 19 Dec 2013 18:52:03 -0500 Date: Thu, 19 Dec 2013 18:52:01 -0500 (EST) Message-Id: <20131219.185201.2268644156166690269.davem@davemloft.net> To: rashika.kheria@gmail.com Cc: linux-kernel@vger.kernel.org, himanshu.madhani@qlogic.com, rajesh.borundia@qlogic.com, shahed.shaikh@qlogic.com, jitendra.kalsaria@qlogic.com, sony.chacko@qlogic.com, sucheta.chakraborty@qlogic.com, linux-driver@qlogic.com, netdev@vger.kernel.org, josh@joshtriplett.org Subject: Re: [PATCH v3 1/8] drivers: net: Mark functions as static in qlcnic_io.c From: David Miller In-Reply-To: <04fe932bc3585620c91d511bb0894e45bb762ffa.1387382457.git.rashika.kheria@gmail.com> References: <04fe932bc3585620c91d511bb0894e45bb762ffa.1387382457.git.rashika.kheria@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.1 (shards.monkeyblade.net [0.0.0.0]); Thu, 19 Dec 2013 15:52:03 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id rBJNqIwu008806 From: Rashika Kheria Date: Thu, 19 Dec 2013 14:17:27 +0530 > This patch marks the function qlcnic_enable_tx_intr(), > qlcnic_83xx_enable_tx_intr() and qlcnic_83xx_disable_tx_intr() in > qlcnic_io.c as static because they are not used outside this file. > > Thus, it also removes the following warnings in > ethernet/qlogic/qlcnic/qlcnic_io.c: > > drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:130:13: warning: no previous prototype for qlcnic_enable_tx_intr [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:147:13: warning: no previous prototype for qlcnic_83xx_enable_tx_intr [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:153:13: warning: no previous prototype for qlcnic_83xx_disable_tx_intr [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria > Reviewed-by: Josh Triplett Applied. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 1/8] drivers: net: Mark functions as static in qlcnic_io.c Date: Thu, 19 Dec 2013 18:52:01 -0500 (EST) Message-ID: <20131219.185201.2268644156166690269.davem@davemloft.net> References: <04fe932bc3585620c91d511bb0894e45bb762ffa.1387382457.git.rashika.kheria@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 Content-Transfer-Encoding: base64 Cc: linux-kernel@vger.kernel.org, himanshu.madhani@qlogic.com, rajesh.borundia@qlogic.com, shahed.shaikh@qlogic.com, jitendra.kalsaria@qlogic.com, sony.chacko@qlogic.com, sucheta.chakraborty@qlogic.com, linux-driver@qlogic.com, netdev@vger.kernel.org, josh@joshtriplett.org To: rashika.kheria@gmail.com Return-path: In-Reply-To: <04fe932bc3585620c91d511bb0894e45bb762ffa.1387382457.git.rashika.kheria@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org RnJvbTogUmFzaGlrYSBLaGVyaWEgPHJhc2hpa2Eua2hlcmlhQGdtYWlsLmNvbT4NCkRhdGU6IFRo dSwgMTkgRGVjIDIwMTMgMTQ6MTc6MjcgKzA1MzANCg0KPiBUaGlzIHBhdGNoIG1hcmtzIHRoZSBm dW5jdGlvbiBxbGNuaWNfZW5hYmxlX3R4X2ludHIoKSwNCj4gcWxjbmljXzgzeHhfZW5hYmxlX3R4 X2ludHIoKSBhbmQgcWxjbmljXzgzeHhfZGlzYWJsZV90eF9pbnRyKCkgaW4NCj4gcWxjbmljX2lv LmMgYXMgc3RhdGljIGJlY2F1c2UgdGhleSBhcmUgbm90IHVzZWQgb3V0c2lkZSB0aGlzIGZpbGUu DQo+IA0KPiBUaHVzLCBpdCBhbHNvIHJlbW92ZXMgdGhlIGZvbGxvd2luZyB3YXJuaW5ncyBpbg0K PiBldGhlcm5ldC9xbG9naWMvcWxjbmljL3FsY25pY19pby5jOg0KPiANCj4gZHJpdmVycy9uZXQv ZXRoZXJuZXQvcWxvZ2ljL3FsY25pYy9xbGNuaWNfaW8uYzoxMzA6MTM6IHdhcm5pbmc6IG5vIHBy ZXZpb3VzIHByb3RvdHlwZSBmb3IgoXFsY25pY19lbmFibGVfdHhfaW50cqIgWy1XbWlzc2luZy1w cm90b3R5cGVzXQ0KPiBkcml2ZXJzL25ldC9ldGhlcm5ldC9xbG9naWMvcWxjbmljL3FsY25pY19p by5jOjE0NzoxMzogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciChcWxjbmljXzgz eHhfZW5hYmxlX3R4X2ludHKiIFstV21pc3NpbmctcHJvdG90eXBlc10NCj4gZHJpdmVycy9uZXQv ZXRoZXJuZXQvcWxvZ2ljL3FsY25pYy9xbGNuaWNfaW8uYzoxNTM6MTM6IHdhcm5pbmc6IG5vIHBy ZXZpb3VzIHByb3RvdHlwZSBmb3IgoXFsY25pY184M3h4X2Rpc2FibGVfdHhfaW50cqIgWy1XbWlz c2luZy1wcm90b3R5cGVzXQ0KPiANCj4gU2lnbmVkLW9mZi1ieTogUmFzaGlrYSBLaGVyaWEgPHJh c2hpa2Eua2hlcmlhQGdtYWlsLmNvbT4NCj4gUmV2aWV3ZWQtYnk6IEpvc2ggVHJpcGxldHQgPGpv c2hAam9zaHRyaXBsZXR0Lm9yZz4NCg0KQXBwbGllZC4NCg==