From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58865)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VteLx-0002Iz-Bd
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 09:13:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VteLr-0006cW-Bk
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 09:13:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21383)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VteLr-0006cM-4G
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 09:13:23 -0500
Date: Thu, 19 Dec 2013 16:16:58 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131219141658.GD10117@redhat.com>
References: <1386951736-929-1-git-send-email-imammedo@redhat.com>
	<1386951736-929-6-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1386951736-929-6-git-send-email-imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 05/11] acpi: ich9: allow guest to clear SCI
	rised by GPE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: stefanha@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, brogers@suse.com, jjherne@us.ibm.com, kraxel@redhat.com, aliguori@amazon.com, kaneshige.kenji@jp.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, pbonzini@redhat.com, lersek@redhat.com

On Fri, Dec 13, 2013 at 05:22:10PM +0100, Igor Mammedov wrote:
> it fixes IRQ storm since guest isn't able to lower SCI IRQ
> after it has been handled when it clears GPE event.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Applied, thanks.

> ---
>  hw/acpi/ich9.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index dcdef7c..30f0df8 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -61,6 +61,7 @@ static void ich9_gpe_writeb(void *opaque, hwaddr addr, uint64_t val,
>  {
>      ICH9LPCPMRegs *pm = opaque;
>      acpi_gpe_ioport_writeb(&pm->acpi_regs, addr, val);
> +    acpi_update_sci(&pm->acpi_regs, pm->irq);
>  }
>  
>  static const MemoryRegionOps ich9_gpe_ops = {
> -- 
> 1.8.3.1