All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Deegan <tim@xen.org>
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [RFC PATCH] PVH: cleanup of p2m upon p2m destroy
Date: Fri, 20 Dec 2013 10:22:40 +0100	[thread overview]
Message-ID: <20131220092240.GA8898@deinos.phlegethon.org> (raw)
In-Reply-To: <20131219180009.01d61971@mantra.us.oracle.com>

Hi,

At 18:00 -0800 on 19 Dec (1387472409), Mukesh Rathor wrote:
> On Thu, 19 Dec 2013 11:50:58 +0100 Tim Deegan <tim@xen.org> wrote:
> > At 18:01 -0800 on 18 Dec (1387386115), Mukesh Rathor wrote:
> > > No, not quite, because I need to know which mfns are foreign and
> > > do put_page on them. 
> > 
> > Oh right, but you need to do that anyway -- once you've got refcounts
> > held by ept entries, you need to do _all_ entry writes through the
> > function that preserves the refcount invariant.  So
> > p2m_change_entry_type_global() has to use that function too, in case
> > either of the types it's called with is p2m_foreign.  And once that's
> > fixed, a call to s/foreign/invalid/ DTRT.
> 
> Right, right... i keep not realizing, it's there now and it's use
> will scope beyond the current PVH usage. So rather than deferring to
> when someone actually finds a use case for p2m_change_entry_type_global
> using foreign, i should be handled now. 
> 
> I'll have next, un-rushed this time, patch prob first week of jan 
> given the upcoming holidays.

Great!  Looking forward to it.  Happy holidays in the meantime. :)

Tim.

  reply	other threads:[~2013-12-20  9:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  1:47 [RFC PATCH] PVH: cleanup of p2m upon p2m destroy Mukesh Rathor
2013-12-17  8:42 ` Jan Beulich
2013-12-17 10:19   ` Tim Deegan
2013-12-18  2:44     ` Mukesh Rathor
2013-12-18 10:03       ` Jan Beulich
2013-12-18 11:32         ` Dietmar Hahn
2013-12-18 10:09       ` Tim Deegan
2013-12-18 16:51         ` Tim Deegan
2013-12-19  2:01           ` Mukesh Rathor
2013-12-19 10:50             ` Tim Deegan
2013-12-20  2:00               ` Mukesh Rathor
2013-12-20  9:22                 ` Tim Deegan [this message]
2014-02-01  2:38           ` Mukesh Rathor
2014-02-03 10:12             ` Tim Deegan
2013-12-20 13:58         ` George Dunlap
2013-12-20 14:29           ` Tim Deegan
2013-12-18  1:01   ` Mukesh Rathor
2013-12-18  8:12     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131220092240.GA8898@deinos.phlegethon.org \
    --to=tim@xen.org \
    --cc=JBeulich@suse.com \
    --cc=mukesh.rathor@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.