From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56266)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vtx0S-0002ea-DA
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 05:08:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vtx0J-0006oq-Rw
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 05:08:32 -0500
Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:32955)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Vtx0J-0006ol-M5
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 05:08:23 -0500
Received: by mail-we0-f174.google.com with SMTP id q58so2208954wes.5
	for <qemu-devel@nongnu.org>; Fri, 20 Dec 2013 02:08:23 -0800 (PST)
Date: Fri, 20 Dec 2013 11:08:20 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131220100820.GC27021@stefanha-thinkpad.redhat.com>
References: <cover.1387419339.git.hutao@cn.fujitsu.com>
	<c6cb3e837464999ec730242b62fddca670aeb39e.1387419339.git.hutao@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c6cb3e837464999ec730242b62fddca670aeb39e.1387419339.git.hutao@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [RFC PATCH v3 1/6] block: introduce prealloc_mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org

On Thu, Dec 19, 2013 at 10:27:36AM +0800, Hu Tao wrote:
> diff --git a/include/block/block.h b/include/block/block.h
> index 36efaea..3732f25 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -527,4 +527,10 @@ int bdrv_debug_remove_breakpoint(BlockDriverState *bs, const char *tag);
>  int bdrv_debug_resume(BlockDriverState *bs, const char *tag);
>  bool bdrv_debug_is_suspended(BlockDriverState *bs, const char *tag);
>  
> +enum prealloc_mode {

Please follow modern QEMU coding style and use CamelCase: PreallocMode

It would be nice to use PreallocMode instead int for variables.