From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] block: null_blk: fix queue leak inside removing device
Date: Mon, 23 Dec 2013 08:26:50 -0800 [thread overview]
Message-ID: <20131223162650.GC9383@infradead.org> (raw)
In-Reply-To: <1387815539-12257-4-git-send-email-tom.leiming@gmail.com>
On Tue, Dec 24, 2013 at 12:18:58AM +0800, Ming Lei wrote:
> del_gendisk(nullb->disk);
> - if (queue_mode == NULL_Q_MQ)
> - blk_mq_free_queue(nullb->q);
> - else
> - blk_cleanup_queue(nullb->q);
> + blk_cleanup_queue(nullb->q);
All exported users of blk_mq_free_queue go away with this change, so
make sure it's not available anymore. I have to say the one in
blk-sysfs.c also looks suspicious.
next prev parent reply other threads:[~2013-12-23 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 16:18 [PATCH 0/4] block: blk-mq: support blk_cleanup_queue on mq Ming Lei
2013-12-23 16:18 ` [PATCH 1/4] block: blk-mq: support draining mq queue Ming Lei
2013-12-23 16:24 ` Christoph Hellwig
2013-12-24 3:30 ` Ming Lei
2013-12-26 9:45 ` Christoph Hellwig
2013-12-26 10:12 ` Ming Lei
2013-12-26 10:53 ` Christoph Hellwig
2013-12-23 16:18 ` [PATCH 2/4] block: blk-mq: make blk_sync_queue support mq Ming Lei
2013-12-23 16:25 ` Christoph Hellwig
2013-12-24 3:35 ` Ming Lei
2013-12-23 16:18 ` [PATCH 3/4] block: null_blk: fix queue leak inside removing device Ming Lei
2013-12-23 16:26 ` Christoph Hellwig [this message]
2013-12-23 16:18 ` [PATCH 4/4] block: blk-mq: don't export blk_mq_free_queue() Ming Lei
2013-12-23 16:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131223162650.GC9383@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.