From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758243Ab3LWWoi (ORCPT ); Mon, 23 Dec 2013 17:44:38 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:22727 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752426Ab3LWWog (ORCPT ); Mon, 23 Dec 2013 17:44:36 -0500 Date: Mon, 23 Dec 2013 23:44:35 +0100 From: Ludovic Desroches To: Joonsoo Kim , , , , CC: Ludovic Desroches Subject: Re: possible regression on 3.13 when calling flush_dcache_page Message-ID: <20131223224435.GD16592@ldesroches-Latitude-E6320> Mail-Followup-To: Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20131212143149.GI12099@ldesroches-Latitude-E6320> <20131212143618.GJ12099@ldesroches-Latitude-E6320> <20131213015909.GA8845@lge.com> <20131216144343.GD9627@ldesroches-Latitude-E6320> <20131218072117.GA2383@lge.com> <20131220080851.GC16592@ldesroches-Latitude-E6320> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20131220080851.GC16592@ldesroches-Latitude-E6320> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 20, 2013 at 09:08:51AM +0100, Ludovic Desroches wrote: > Hello, > > On Wed, Dec 18, 2013 at 04:21:17PM +0900, Joonsoo Kim wrote: > > On Mon, Dec 16, 2013 at 03:43:43PM +0100, Ludovic Desroches wrote: > > > Hello, > > > > > > On Fri, Dec 13, 2013 at 10:59:09AM +0900, Joonsoo Kim wrote: > > > > On Thu, Dec 12, 2013 at 03:36:19PM +0100, Ludovic Desroches wrote: > > > > > fix mmc mailing list address error > > > > > > > > > > On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > > > > > > Hi, > > > > > > > > > > > > With v3.13-rc3 I have an error when the atmel-mci driver calls > > > > > > flush_dcache_page (log at the end of the message). > > > > > > > > > > > > Since I didn't have it before, I did a git bisect and the commit introducing > > > > > > the error is the following one: > > > > > > > > > > > > 106a74e slab: replace free and inuse in struct slab with newly introduced active > > > > > > > > > > > > I don't know if this commit has introduced a bug or if it has revealed a bug > > > > > > in the atmel-mci driver. > > > > > > > > Hello, > > > > > > > > I think that this commit may not introduce a bug. This patch remove one > > > > variable on slab management structure and replace variable name. So there > > > > is no functional change. > > > > > > > > > > If I have reverted this patch and other ones you did on top of it and > > > the issue disappear. > > > > Hello, > > > > Could you give me your '/proc/slabinfo' before/after this commit (106a74e)? > > > > And how about testing with artificially increasing size of struct slab on > > top of this commit (106a74e)? > > > > I really wonder why the problem happens, because this doesn't cause any > > functional change as far as I know. Only side-effect from this patch is > > decreasing size of struct slab. > > Sorry I am not at the office, I have tried to reproduce it with a > different device and a different sdcard but without success. I'll test > it on Monday. I am still not at the office but I get the same device and the same sdcard and I don't reproduce it. I am not totally in the same conditions. It seems there is an extra parameter causing this bug but I don't figure out which one at the moment. > > Regards > > Ludovic > > > > > Thanks. > > > > diff --git a/mm/slab.c b/mm/slab.c > > index 2ec2336..d2240fd 100644 > > --- a/mm/slab.c > > +++ b/mm/slab.c > > @@ -174,6 +174,7 @@ struct slab { > > struct { > > struct list_head list; > > void *s_mem; /* including colour offset */ > > + unsigned int x; > > unsigned int active; /* num of objs active in slab */ > > }; > > }; > > > > > > > > > I doubt that side-effect of this patch reveals a bug in other place. > > > > Side-effect is reduced memory usage for slab management structure. It would > > > > makes some slabs have more objects with more density since slab management > > > > structure is sometimes on the page for objects. So if it diminishes, more > > > > objects can be in the page. > > > > > > > > Anyway, I will look at it more. If you have any progress, please let me know. > > > > > > No progress at the moment. > > > > -- > > To unsubscribe, send a message with 'unsubscribe linux-mm' in > > the body to majordomo@kvack.org. For more info on Linux MM, > > see: http://www.linux-mm.org/ . > > Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic Desroches Subject: Re: possible regression on 3.13 when calling flush_dcache_page Date: Mon, 23 Dec 2013 23:44:35 +0100 Message-ID: <20131223224435.GD16592@ldesroches-Latitude-E6320> References: <20131212143149.GI12099@ldesroches-Latitude-E6320> <20131212143618.GJ12099@ldesroches-Latitude-E6320> <20131213015909.GA8845@lge.com> <20131216144343.GD9627@ldesroches-Latitude-E6320> <20131218072117.GA2383@lge.com> <20131220080851.GC16592@ldesroches-Latitude-E6320> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20131220080851.GC16592@ldesroches-Latitude-E6320> Sender: owner-linux-mm@kvack.org To: Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Ludovic Desroches List-Id: linux-mmc@vger.kernel.org On Fri, Dec 20, 2013 at 09:08:51AM +0100, Ludovic Desroches wrote: > Hello, > > On Wed, Dec 18, 2013 at 04:21:17PM +0900, Joonsoo Kim wrote: > > On Mon, Dec 16, 2013 at 03:43:43PM +0100, Ludovic Desroches wrote: > > > Hello, > > > > > > On Fri, Dec 13, 2013 at 10:59:09AM +0900, Joonsoo Kim wrote: > > > > On Thu, Dec 12, 2013 at 03:36:19PM +0100, Ludovic Desroches wrote: > > > > > fix mmc mailing list address error > > > > > > > > > > On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > > > > > > Hi, > > > > > > > > > > > > With v3.13-rc3 I have an error when the atmel-mci driver calls > > > > > > flush_dcache_page (log at the end of the message). > > > > > > > > > > > > Since I didn't have it before, I did a git bisect and the commit introducing > > > > > > the error is the following one: > > > > > > > > > > > > 106a74e slab: replace free and inuse in struct slab with newly introduced active > > > > > > > > > > > > I don't know if this commit has introduced a bug or if it has revealed a bug > > > > > > in the atmel-mci driver. > > > > > > > > Hello, > > > > > > > > I think that this commit may not introduce a bug. This patch remove one > > > > variable on slab management structure and replace variable name. So there > > > > is no functional change. > > > > > > > > > > If I have reverted this patch and other ones you did on top of it and > > > the issue disappear. > > > > Hello, > > > > Could you give me your '/proc/slabinfo' before/after this commit (106a74e)? > > > > And how about testing with artificially increasing size of struct slab on > > top of this commit (106a74e)? > > > > I really wonder why the problem happens, because this doesn't cause any > > functional change as far as I know. Only side-effect from this patch is > > decreasing size of struct slab. > > Sorry I am not at the office, I have tried to reproduce it with a > different device and a different sdcard but without success. I'll test > it on Monday. I am still not at the office but I get the same device and the same sdcard and I don't reproduce it. I am not totally in the same conditions. It seems there is an extra parameter causing this bug but I don't figure out which one at the moment. > > Regards > > Ludovic > > > > > Thanks. > > > > diff --git a/mm/slab.c b/mm/slab.c > > index 2ec2336..d2240fd 100644 > > --- a/mm/slab.c > > +++ b/mm/slab.c > > @@ -174,6 +174,7 @@ struct slab { > > struct { > > struct list_head list; > > void *s_mem; /* including colour offset */ > > + unsigned int x; > > unsigned int active; /* num of objs active in slab */ > > }; > > }; > > > > > > > > > I doubt that side-effect of this patch reveals a bug in other place. > > > > Side-effect is reduced memory usage for slab management structure. It would > > > > makes some slabs have more objects with more density since slab management > > > > structure is sometimes on the page for objects. So if it diminishes, more > > > > objects can be in the page. > > > > > > > > Anyway, I will look at it more. If you have any progress, please let me know. > > > > > > No progress at the moment. > > > > -- > > To unsubscribe, send a message with 'unsubscribe linux-mm' in > > the body to majordomo@kvack.org. For more info on Linux MM, > > see: http://www.linux-mm.org/ . > > Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches@atmel.com (Ludovic Desroches) Date: Mon, 23 Dec 2013 23:44:35 +0100 Subject: possible regression on 3.13 when calling flush_dcache_page In-Reply-To: <20131220080851.GC16592@ldesroches-Latitude-E6320> References: <20131212143149.GI12099@ldesroches-Latitude-E6320> <20131212143618.GJ12099@ldesroches-Latitude-E6320> <20131213015909.GA8845@lge.com> <20131216144343.GD9627@ldesroches-Latitude-E6320> <20131218072117.GA2383@lge.com> <20131220080851.GC16592@ldesroches-Latitude-E6320> Message-ID: <20131223224435.GD16592@ldesroches-Latitude-E6320> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Dec 20, 2013 at 09:08:51AM +0100, Ludovic Desroches wrote: > Hello, > > On Wed, Dec 18, 2013 at 04:21:17PM +0900, Joonsoo Kim wrote: > > On Mon, Dec 16, 2013 at 03:43:43PM +0100, Ludovic Desroches wrote: > > > Hello, > > > > > > On Fri, Dec 13, 2013 at 10:59:09AM +0900, Joonsoo Kim wrote: > > > > On Thu, Dec 12, 2013 at 03:36:19PM +0100, Ludovic Desroches wrote: > > > > > fix mmc mailing list address error > > > > > > > > > > On Thu, Dec 12, 2013 at 03:31:50PM +0100, Ludovic Desroches wrote: > > > > > > Hi, > > > > > > > > > > > > With v3.13-rc3 I have an error when the atmel-mci driver calls > > > > > > flush_dcache_page (log at the end of the message). > > > > > > > > > > > > Since I didn't have it before, I did a git bisect and the commit introducing > > > > > > the error is the following one: > > > > > > > > > > > > 106a74e slab: replace free and inuse in struct slab with newly introduced active > > > > > > > > > > > > I don't know if this commit has introduced a bug or if it has revealed a bug > > > > > > in the atmel-mci driver. > > > > > > > > Hello, > > > > > > > > I think that this commit may not introduce a bug. This patch remove one > > > > variable on slab management structure and replace variable name. So there > > > > is no functional change. > > > > > > > > > > If I have reverted this patch and other ones you did on top of it and > > > the issue disappear. > > > > Hello, > > > > Could you give me your '/proc/slabinfo' before/after this commit (106a74e)? > > > > And how about testing with artificially increasing size of struct slab on > > top of this commit (106a74e)? > > > > I really wonder why the problem happens, because this doesn't cause any > > functional change as far as I know. Only side-effect from this patch is > > decreasing size of struct slab. > > Sorry I am not at the office, I have tried to reproduce it with a > different device and a different sdcard but without success. I'll test > it on Monday. I am still not at the office but I get the same device and the same sdcard and I don't reproduce it. I am not totally in the same conditions. It seems there is an extra parameter causing this bug but I don't figure out which one at the moment. > > Regards > > Ludovic > > > > > Thanks. > > > > diff --git a/mm/slab.c b/mm/slab.c > > index 2ec2336..d2240fd 100644 > > --- a/mm/slab.c > > +++ b/mm/slab.c > > @@ -174,6 +174,7 @@ struct slab { > > struct { > > struct list_head list; > > void *s_mem; /* including colour offset */ > > + unsigned int x; > > unsigned int active; /* num of objs active in slab */ > > }; > > }; > > > > > > > > > I doubt that side-effect of this patch reveals a bug in other place. > > > > Side-effect is reduced memory usage for slab management structure. It would > > > > makes some slabs have more objects with more density since slab management > > > > structure is sometimes on the page for objects. So if it diminishes, more > > > > objects can be in the page. > > > > > > > > Anyway, I will look at it more. If you have any progress, please let me know. > > > > > > No progress at the moment. > > > > -- > > To unsubscribe, send a message with 'unsubscribe linux-mm' in > > the body to majordomo at kvack.org. For more info on Linux MM, > > see: http://www.linux-mm.org/ . > > Don't email: email at kvack.org