From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH RFC 03/13] xen: mask event channels while changing affinity Date: Fri, 3 Jan 2014 15:45:34 -0500 Message-ID: <20140103204534.GA2732__18836.63258418$1388782096$gmane$org@phenom.dumpdata.com> References: <1387884062-41154-1-git-send-email-roger.pau@citrix.com> <1387884062-41154-4-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VzBcs-0007RR-K9 for xen-devel@lists.xenproject.org; Fri, 03 Jan 2014 20:45:50 +0000 Content-Disposition: inline In-Reply-To: <1387884062-41154-4-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: jhb@freebsd.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, xen-devel@lists.xenproject.org, gibbs@freebsd.org List-Id: xen-devel@lists.xenproject.org On Tue, Dec 24, 2013 at 12:20:52PM +0100, Roger Pau Monne wrote: > Event channels should be masked while chaning affinity, or else we changing > might get spurious/lost interrupts. > --- > sys/x86/xen/xen_intr.c | 15 ++++++++++++--- > 1 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/sys/x86/xen/xen_intr.c b/sys/x86/xen/xen_intr.c > index fd36e68..bc0781e 100644 > --- a/sys/x86/xen/xen_intr.c > +++ b/sys/x86/xen/xen_intr.c > @@ -797,7 +797,7 @@ xen_intr_assign_cpu(struct intsrc *base_isrc, u_int apic_id) > struct evtchn_bind_vcpu bind_vcpu; > struct xenisrc *isrc; > u_int to_cpu, vcpu_id; > - int error; > + int error, masked; > > #ifdef XENHVM > if (xen_vector_callback_enabled == 0) > @@ -815,6 +815,12 @@ xen_intr_assign_cpu(struct intsrc *base_isrc, u_int apic_id) > return (EINVAL); > } > > + /* > + * Mask the event channel port so we don't receive spurious events > + * while changing affinity. > + */ > + masked = evtchn_test_and_set_mask(isrc->xi_port); > + > if ((isrc->xi_type == EVTCHN_TYPE_VIRQ) || > (isrc->xi_type == EVTCHN_TYPE_IPI)) { > /* > @@ -825,8 +831,7 @@ xen_intr_assign_cpu(struct intsrc *base_isrc, u_int apic_id) > evtchn_cpu_mask_port(isrc->xi_cpu, isrc->xi_port); > isrc->xi_cpu = to_cpu; > evtchn_cpu_unmask_port(isrc->xi_cpu, isrc->xi_port); > - mtx_unlock(&xen_intr_isrc_lock); > - return (0); > + goto out; > } > > bind_vcpu.port = isrc->xi_port; > @@ -848,6 +853,10 @@ xen_intr_assign_cpu(struct intsrc *base_isrc, u_int apic_id) > evtchn_cpu_mask_port(to_cpu, isrc->xi_port); > } > } > + > +out: > + if (!masked) > + evtchn_unmask_port(isrc->xi_port); > mtx_unlock(&xen_intr_isrc_lock); > return (0); > #else > -- > 1.7.7.5 (Apple Git-26) > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel