From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbaAERK6 (ORCPT ); Sun, 5 Jan 2014 12:10:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41633 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbaAERK4 (ORCPT ); Sun, 5 Jan 2014 12:10:56 -0500 Date: Sun, 5 Jan 2014 18:10:36 +0100 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Namhyung Kim , LKML , Arun Sharma , Frederic Weisbecker , Rodrigo Campos Subject: Re: [PATCH 07/21] perf report: Cache cumulative callchains Message-ID: <20140105171036.GG10018@krava.brq.redhat.com> References: <1387873347-28838-1-git-send-email-namhyung@kernel.org> <1387873347-28838-8-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1387873347-28838-8-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 24, 2013 at 05:22:13PM +0900, Namhyung Kim wrote: > From: Namhyung Kim > SNIP > return hist_entry__inc_addr_samples(he, evsel->idx, al->addr); > } > > @@ -476,6 +522,8 @@ iter_finish_cumulative_entry(struct add_entry_iter *iter, > evsel->hists.stats.total_period += sample->period; > hists__inc_nr_events(&evsel->hists, PERF_RECORD_SAMPLE); > > + free(iter->priv); > + iter->priv = NULL; zfree ;-) jirka