From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [BUGFIX][PATCH 1/4] dbg_rw_guest_mem: need to call
 put_gfn in error path.
Date: Mon, 6 Jan 2014 16:41:27 -0800
Message-ID: <20140106164127.556d654e@mantra.us.oracle.com>
References: <1388857936-664-1-git-send-email-dslutz@verizon.com>
	<1388857936-664-2-git-send-email-dslutz@verizon.com>
	<52C9E621.4020608@citrix.com> <52CAA503.5080707@terremark.com>
	<52CAABF8.30702@citrix.com> <52CB0922.1030209@terremark.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52CB0922.1030209@terremark.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 06 Jan 2014 14:50:58 -0500
Don Slutz <dslutz@verizon.com> wrote:

> On 01/06/14 08:13, Andrew Cooper wrote:
> > On 06/01/14 12:43, Don Slutz wrote:
> >> On 01/05/14 18:09, Andrew Cooper wrote:
> >>> On 04/01/2014 17:52, Don Slutz wrote:
> >>>> Using a 1G hvm domU (in grub) and gdbsx:
> >>>>
......
> >>> Content-wise, I think it would be better to fix up the error path
> >>> in dbg_hvm_va2mfn() so it doesn't exit with INVALID_MFN having
> >>> taken a reference on the gfn.

Right, that is similar to what I had done when I had noticed this early this
year. I had just changed to nolock query since the domain is paused during
this call, but in hindsight it's better to do locked query. So I prefer
doing in dbg_hvm_va2mfn() too.

http://lists.xen.org/archives/html/xen-devel/2013-01/msg00781.html

Will wait for your v2 you said you will be submitting.

thanks,
mukesh