All of lore.kernel.org
 help / color / mirror / Atom feed
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] arm64: topology: Implement basic CPU topology support
Date: Thu, 9 Jan 2014 12:40:43 +0000	[thread overview]
Message-ID: <20140109124042.GA6089@e102568-lin.cambridge.arm.com> (raw)
In-Reply-To: <20140108184021.GW31886@sirena.org.uk>

On Wed, Jan 08, 2014 at 06:40:21PM +0000, Mark Brown wrote:
> On Wed, Jan 08, 2014 at 06:30:06PM +0000, Lorenzo Pieralisi wrote:
> > On Wed, Jan 08, 2014 at 05:10:10PM +0000, Mark Brown wrote:
> 
> > > +#include <linux/slab.h>
> 
> > Nitpick, <linux/slab.h> does not belong in this patch. There are other
> > includes that should be moved to the respective patch (percpu.h ?) where
> > they are actually used.
> 
> I can move this one but honestly I'm having an extremely difficult time
> summoning up the enthusiasm for looking for others and moving them - the
> practical impact will not be substantial.

Ok, it is your call and I understand I am being pedantic but from a logical
patch split perspective that's not correct and honestly it should take no more
than few minutes to move the includes where they actually belong.

Lorenzo

  reply	other threads:[~2014-01-09 12:40 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 17:10 [PATCH 1/4] arm64: topology: Implement basic CPU topology support Mark Brown
2014-01-08 17:10 ` [PATCH 2/4] arm64: topology: Add support for topology DT bindings Mark Brown
2014-01-08 18:23   ` Lorenzo Pieralisi
2014-01-08 18:32     ` Mark Brown
2014-01-08 17:10 ` [PATCH 3/4] arm64: topology: Tell the scheduler about the relative power of cores Mark Brown
2014-01-08 18:39   ` Lorenzo Pieralisi
2014-01-08 18:45     ` Mark Brown
2014-01-08 17:10 ` [PATCH 4/4] arm64: topology: Provide relative power numbers for cores Mark Brown
2014-01-08 18:30 ` [PATCH 1/4] arm64: topology: Implement basic CPU topology support Lorenzo Pieralisi
2014-01-08 18:40   ` Mark Brown
2014-01-09 12:40     ` Lorenzo Pieralisi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-02-26  0:48 [PATCH 0/4] arm64: Topology Mark Brown
2014-02-26  0:48 ` [PATCH 1/4] arm64: topology: Implement basic CPU topology support Mark Brown
2014-02-25  4:25 [PATCH 0/4] arm64: topology: " Mark Brown
2014-02-25  4:25 ` [PATCH 1/4] arm64: topology: Implement basic " Mark Brown
2014-02-25 16:54   ` Lorenzo Pieralisi
2014-02-26  0:50     ` Mark Brown
2014-02-26 12:32       ` Lorenzo Pieralisi
2014-02-26 14:46         ` Mark Brown
2014-02-26 15:48           ` Catalin Marinas
2014-02-26 17:50             ` Lorenzo Pieralisi
2014-02-27  4:30               ` Mark Brown
2014-02-27  4:20             ` Mark Brown
2014-02-11 22:06 Mark Brown
2014-02-10 13:02 Mark Brown
2014-02-10 16:22 ` Catalin Marinas
2014-02-10 16:46   ` Mark Brown
2014-02-11  8:15     ` Vincent Guittot
2014-02-11 10:34       ` Will Deacon
2014-02-11 13:18         ` Vincent Guittot
2014-02-11 14:07           ` Catalin Marinas
2014-02-11 14:46             ` Vincent Guittot
2014-02-11 22:04               ` Mark Brown
2014-02-12  8:04             ` Vincent Guittot
2014-02-12 10:27               ` Catalin Marinas
2014-02-12 12:34                 ` Mark Brown
2014-02-21 15:01 ` Lorenzo Pieralisi
2014-02-22  2:06   ` Mark Brown
2014-02-22 12:26     ` Lorenzo Pieralisi
2014-02-23  2:09       ` Mark Brown
2014-01-15 11:38 [PATCH v12 0/4] arm64 topology Mark Brown
2014-01-15 11:38 ` [PATCH 1/4] arm64: topology: Implement basic CPU topology support Mark Brown
2014-01-12 19:20 [PATCH v11 0/4] ARMv8 cpu topology Mark Brown
2014-01-12 19:20 ` [PATCH 1/4] arm64: topology: Implement basic CPU topology support Mark Brown
2014-01-13 16:10   ` Lorenzo Pieralisi
2014-01-13 16:30     ` Mark Brown
2014-01-13 17:44       ` Lorenzo Pieralisi
2014-01-14  8:17         ` Vincent Guittot
2014-01-13 16:44     ` Vincent Guittot
2014-01-13 17:33       ` Lorenzo Pieralisi
2014-01-08 19:12 Mark Brown
2014-01-09 11:48 ` Catalin Marinas
2013-12-19 20:06 [PATCH 0/4] arm64 " Mark Brown
2013-12-19 20:06 ` [PATCH 1/4] arm64: topology: Implement basic CPU " Mark Brown
2013-12-16 16:49 Mark Brown
2013-12-17 17:06 ` Lorenzo Pieralisi
2013-12-17 19:55   ` Mark Brown
2013-12-18 17:39     ` Lorenzo Pieralisi
2013-12-18 18:00       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140109124042.GA6089@e102568-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.