From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752682AbaAKKcq (ORCPT ); Sat, 11 Jan 2014 05:32:46 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:44030 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbaAKKco (ORCPT ); Sat, 11 Jan 2014 05:32:44 -0500 Date: Sat, 11 Jan 2014 02:32:35 -0800 From: Christoph Hellwig To: Ben Myers Cc: Christoph Hellwig , Al Viro , "Theodore Ts'o" , Paul Moore , Matthew Wilcox , Stephen Smalley , LKML , Steven Rostedt , xfs@oss.sgi.com, Eric Paris , James Morris , linux-fsdevel , stable , Andrew Morton , Paul McKenney , Linus Torvalds Subject: Re: [PATCH] vfs: Fix possible NULL pointer dereference in inode_permission() Message-ID: <20140111103234.GC22098@infradead.org> References: <20140109165012.391db81e@gandalf.local.home> <20140109223127.GM10323@ZenIV.linux.org.uk> <20140109182523.5b50131f@gandalf.local.home> <20140109182756.17abaaa8@gandalf.local.home> <1389310626.15209.92.camel@localhost> <20140110000642.GN10323@ZenIV.linux.org.uk> <20140110093148.GA26159@infradead.org> <20140110181434.GH1935@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140110181434.GH1935@sgi.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2014 at 12:14:34PM -0600, Ben Myers wrote: > > What's really needed there to make XFS behave more similar to everyone > > else is a way for the filesystem to say: "I can't actually free this > > inode right now, but I'll come back to you later". > > This test might read something like: "If my link count has gone to zero, and I > am the last inode in my cluster to be freed, and there are other inodes from my > cluster incore, I cannot be freed." It's more complicated than that. In theory we would free the inode easily as soon as the VFS wants it, but performance would be horrible as we would have to synchronously write back the inode. Note that it really matters for the interface, that just needs to be an: I won't free this right now, but I'll call you back later when I can. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] vfs: Fix possible NULL pointer dereference in inode_permission() Date: Sat, 11 Jan 2014 02:32:35 -0800 Message-ID: <20140111103234.GC22098@infradead.org> References: <20140109165012.391db81e@gandalf.local.home> <20140109223127.GM10323@ZenIV.linux.org.uk> <20140109182523.5b50131f@gandalf.local.home> <20140109182756.17abaaa8@gandalf.local.home> <1389310626.15209.92.camel@localhost> <20140110000642.GN10323@ZenIV.linux.org.uk> <20140110093148.GA26159@infradead.org> <20140110181434.GH1935@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Theodore Ts'o , Paul Moore , Matthew Wilcox , Linus Torvalds , Eric Paris , LKML , Steven Rostedt , xfs@oss.sgi.com, Christoph Hellwig , Al Viro , James Morris , linux-fsdevel , stable , Andrew Morton , Paul McKenney , Stephen Smalley To: Ben Myers Return-path: Content-Disposition: inline In-Reply-To: <20140110181434.GH1935@sgi.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-fsdevel.vger.kernel.org On Fri, Jan 10, 2014 at 12:14:34PM -0600, Ben Myers wrote: > > What's really needed there to make XFS behave more similar to everyone > > else is a way for the filesystem to say: "I can't actually free this > > inode right now, but I'll come back to you later". > > This test might read something like: "If my link count has gone to zero, and I > am the last inode in my cluster to be freed, and there are other inodes from my > cluster incore, I cannot be freed." It's more complicated than that. In theory we would free the inode easily as soon as the VFS wants it, but performance would be horrible as we would have to synchronously write back the inode. Note that it really matters for the interface, that just needs to be an: I won't free this right now, but I'll call you back later when I can. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs