From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Herrmann Subject: Re: [PATCH 08/11] of: Increase MAX_PHANDLE_ARGS Date: Fri, 17 Jan 2014 12:00:35 +0100 Message-ID: <20140117110035.GU3471@alberich> References: <1389876263-25759-1-git-send-email-andreas.herrmann@calxeda.com> <1389876263-25759-9-git-send-email-andreas.herrmann@calxeda.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Rob Herring Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Will Deacon , Linux IOMMU , Rob Herring , Grant Likely , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Thu, Jan 16, 2014 at 09:25:59AM -0500, Rob Herring wrote: > On Thu, Jan 16, 2014 at 6:44 AM, Andreas Herrmann > wrote: > > arm-smmu driver uses of_parse_phandle_with_args when parsing DT > > information to determine stream IDs for a master device. > > Thus the number of stream IDs per master device is bound by > > MAX_PHANDLE_ARGS. > > > > To support Calxeda ECX-2000 hardware arm-smmu driver requires a > > slightly higher value for MAX_PHANDLE_ARGS as this hardware has 10 > > stream IDs for one master device. > > > > Cc: Grant Likely > > Cc: Rob Herring > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Cc: Andreas Herrmann > > Signed-off-by: Andreas Herrmann > > Acked-by: Rob Herring > > One comment below... > > > --- > > include/linux/of.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/of.h b/include/linux/of.h > > index 276c546..0807af8 100644 > > --- a/include/linux/of.h > > +++ b/include/linux/of.h > > @@ -67,7 +67,7 @@ struct device_node { > > #endif > > }; > > > > -#define MAX_PHANDLE_ARGS 8 > > +#define MAX_PHANDLE_ARGS 10 > > Just bump this to 16. This is normally just a temporary on the stack > and 8 more words on the stack is not going to cost much. Yes, that seems reasonable. Thanks, Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 From: andreas.herrmann@calxeda.com (Andreas Herrmann) Date: Fri, 17 Jan 2014 12:00:35 +0100 Subject: [PATCH 08/11] of: Increase MAX_PHANDLE_ARGS In-Reply-To: References: <1389876263-25759-1-git-send-email-andreas.herrmann@calxeda.com> <1389876263-25759-9-git-send-email-andreas.herrmann@calxeda.com> Message-ID: <20140117110035.GU3471@alberich> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 16, 2014 at 09:25:59AM -0500, Rob Herring wrote: > On Thu, Jan 16, 2014 at 6:44 AM, Andreas Herrmann > wrote: > > arm-smmu driver uses of_parse_phandle_with_args when parsing DT > > information to determine stream IDs for a master device. > > Thus the number of stream IDs per master device is bound by > > MAX_PHANDLE_ARGS. > > > > To support Calxeda ECX-2000 hardware arm-smmu driver requires a > > slightly higher value for MAX_PHANDLE_ARGS as this hardware has 10 > > stream IDs for one master device. > > > > Cc: Grant Likely > > Cc: Rob Herring > > Cc: devicetree at vger.kernel.org > > Cc: Andreas Herrmann > > Signed-off-by: Andreas Herrmann > > Acked-by: Rob Herring > > One comment below... > > > --- > > include/linux/of.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/of.h b/include/linux/of.h > > index 276c546..0807af8 100644 > > --- a/include/linux/of.h > > +++ b/include/linux/of.h > > @@ -67,7 +67,7 @@ struct device_node { > > #endif > > }; > > > > -#define MAX_PHANDLE_ARGS 8 > > +#define MAX_PHANDLE_ARGS 10 > > Just bump this to 16. This is normally just a temporary on the stack > and 8 more words on the stack is not going to cost much. Yes, that seems reasonable. Thanks, Andreas