From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 11/13] drm/i915/bdw: collect semaphore error state Date: Thu, 30 Jan 2014 14:58:09 +0000 Message-ID: <20140130145809.GN29091@nuc-i3427.alporthouse.com> References: <1391025333-31587-1-git-send-email-benjamin.widawsky@intel.com> <1391025333-31587-12-git-send-email-benjamin.widawsky@intel.com> <20140130145332.GP9454@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id D85C111ED10 for ; Thu, 30 Jan 2014 06:58:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140130145332.GP9454@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Intel GFX , Ben Widawsky , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 30, 2014 at 04:53:32PM +0200, Ville Syrj=E4l=E4 wrote: > On Wed, Jan 29, 2014 at 11:55:31AM -0800, Ben Widawsky wrote: > > + obj =3D error->semaphore_obj; > > + if (obj) { > = > Chris will come along and change this to > = > if ((obj =3D error->semaphore_obj)) I was merely keeping in style with the rest of the code. Which was probably written by me, so I can't win! -Chris -- = Chris Wilson, Intel Open Source Technology Centre