All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, nsekhar@ti.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	jsarha@ti.com, zonque@gmail.com
Subject: Re: [PATCH 1/4] ASoC: davinci-mcasp: Harmonize the sub hw_params function names
Date: Fri, 31 Jan 2014 15:58:59 +0000	[thread overview]
Message-ID: <20140131155859.GG22609@sirena.org.uk> (raw)
In-Reply-To: <1391087725-4088-2-git-send-email-peter.ujfalusi@ti.com>


[-- Attachment #1.1: Type: text/plain, Size: 401 bytes --]

On Thu, Jan 30, 2014 at 03:15:22PM +0200, Peter Ujfalusi wrote:
> Instead of
> davinci_hw_common_param - for common, I2S/DIT mode settings
> davinci_hw_dit_param - for DIT protocol configuration
> davinci_hw_param - for I2S (and compatible protocols)

I've applied this but please don't put stylistic cleanups like this
before bugfixes in patch serieses - it creates a barrier to applying the
bugfix.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2014-01-31 15:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 13:15 [PATCH 0/4] ASoC: davinci-mcasp: Fix master mode capture (w/o playback) Peter Ujfalusi
2014-01-30 13:15 ` [PATCH 1/4] ASoC: davinci-mcasp: Harmonize the sub hw_params function names Peter Ujfalusi
2014-01-31 15:58   ` Mark Brown [this message]
2014-01-30 13:15 ` [PATCH 2/4] ASoC: davinci-mcasp: Configure xxTDM, xxFMT and xxFMCT registers synchronously Peter Ujfalusi
2014-01-31 15:59   ` Mark Brown
2014-01-30 13:15 ` [PATCH 3/4] ASoC: davinci-mcasp: Return value handling cleanup for mcasp_common_hw_param() Peter Ujfalusi
2014-01-31 16:10   ` Mark Brown
2014-01-30 13:15 ` [PATCH 4/4] ASoC: davinci-mcasp: Code cleanup in davinci_mcasp_hw_params() Peter Ujfalusi
2014-01-31 16:11   ` Mark Brown
2014-02-03 12:47     ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140131155859.GG22609@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=jsarha@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.