From: David Miller <davem@davemloft.net>
To: netdev@vger.kernel.org
Cc: ncardwell@google.com
Subject: inet_diag_dump_icsk() change seems bogus...
Date: Sun, 02 Feb 2014 00:45:38 -0800 (PST) [thread overview]
Message-ID: <20140202.004538.1011276314292086521.davem@davemloft.net> (raw)
Upon further review, commit 70315d22d3c7383f9a508d0aab21e2eb35b2303a
("inet_diag: fix inet_diag_dump_icsk() to use correct state for
timewait sockets") doesn't seem valid to me.
Take a close look at get_tcp4_sock() and get_timewait4_sock() which
you reference in your commit message.
The former always gets it's socket from head->chain and the latter
always gets it's socket from head->twchain.
Yet in this inet_diag_dump_icsk() change, you're changing the
head->chain iterator to check for timewait sockets. That doesn't
seem possible.
Only head->twchain holds timewait sockets, and this code was handling
it correctly already.
What gives?
next reply other threads:[~2014-02-02 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 8:45 David Miller [this message]
2014-02-02 15:43 ` inet_diag_dump_icsk() change seems bogus Neal Cardwell
2014-02-02 18:52 ` Eric Dumazet
2014-02-02 18:59 ` Neal Cardwell
2014-02-02 21:03 ` David Miller
2014-02-03 1:41 ` Neal Cardwell
2014-02-02 21:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140202.004538.1011276314292086521.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.