From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53588)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W9xP6-0006FE-H7
	for qemu-devel@nongnu.org; Sun, 02 Feb 2014 08:48:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W9xP2-00061c-5A
	for qemu-devel@nongnu.org; Sun, 02 Feb 2014 08:48:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21947)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1W9xP1-00060M-UO
	for qemu-devel@nongnu.org; Sun, 02 Feb 2014 08:48:04 -0500
Date: Sun, 2 Feb 2014 15:47:58 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140202134757.GC25713@redhat.com>
References: <20140131190322.GL29329@ERROL.INI.CMU.EDU>
	<52EBFBD5.5010701@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52EBFBD5.5010701@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v2] Add option to switch off FDC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Marcel Apfelbaum <marcel.a@redhat.com>, qemu-devel@nongnu.org, armbru@redhat.com, "Gabriel L. Somlo" <gsomlo@gmail.com>, pbonzini@redhat.com, imammedo@redhat.com, lersek@redhat.com

On Fri, Jan 31, 2014 at 12:39:01PM -0700, Eric Blake wrote:
> On 01/31/2014 12:03 PM, Gabriel L. Somlo wrote:
> > Allow guests to omit the configuration of a floppy disk controller.
> > 
> > Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
> > ---
> > 
> > New in this version:
> > 
> >   - "int have_fdc = 1;" instead of "int no_fdc = 0;"
> > 
> >   - use 8bit field for FDC0's _STA method
> > 
> 
> > 
> > Are we OK with the "mechanism" part, i.e. introducing "have_fdc", and
> > programatically configuring the FDC in pc.c and patching the DSDT
> > based on its value ?
> > 
> 
> >  
> > +DEF("no-fdc", 0, QEMU_OPTION_no_fdc,
> > +    "-no-fdc         disable FDC\n", QEMU_ARCH_I386)
> > +STEXI
> > +@item -no-fdc
> > +@findex -no-fdc
> > +Disable FDC support.
> > +ETEXI
> 
> This is not discoverable via the current state of QMP.  It also has the
> annoyance of being a one-way switch with no way to revert to a default
> state.  Can you make this instead use qemuOpts (maybe looking like '-fdc
> yes' vs. '-fdc no')?

I think Marcel said he's working on an infrastructure to add global
options as machine properties.

> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>