From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbaBBSFv (ORCPT ); Sun, 2 Feb 2014 13:05:51 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:39369 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbaBBSFu convert rfc822-to-8bit (ORCPT ); Sun, 2 Feb 2014 13:05:50 -0500 Date: Sun, 2 Feb 2014 19:06:06 +0100 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, Dave Airlie , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Clark Subject: Re: [PATCH v5 00/23] Message-ID: <20140202190606.6fa193ce@armhf> In-Reply-To: <20140202124358.GD26684@n2100.arm.linux.org.uk> References: <20140202124358.GD26684@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2 Feb 2014 12:43:58 +0000 Russell King - ARM Linux wrote: > On Wed, Jan 29, 2014 at 10:01:22AM +0100, Jean-Francois Moine wrote: > > This patch set contains various extensions to the tda998x driver: > > > > - simplify the i2c read/write > > - code cleanup and fix some small errors > > - use global constants > > - don't read write-only registers > > - add DT support > > - use IRQ for connection status and EDID read > > I discussed these patches with Rob Clark recently, and the conclusion > we came to is that I'll merge them into a git tree, test them, and > once I'm happy I'll send a pull request as appropriate. > > I'll go through them later today. Those patches which have been re- > posted without any change for the last few times (the first few) I'll > take into my git tree today so you don't have to keep re-posting them > (more importantly, I won't have to keep on looking at them either.) Thanks. BTW, I found some problems with the patch 12 'add DT support' you already acked: - the .of_match_table is not needed because the i2c client is created by the i2c subsystem from the 'reg' in the DT, - on encoder_destroy(), the function drm_i2c_encoder_destroy() unregisters the i2c client, so, with a DT, a second encoder_init() would crash. Do you better like a new patch or a fix? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Sun, 2 Feb 2014 19:06:06 +0100 Subject: [PATCH v5 00/23] In-Reply-To: <20140202124358.GD26684@n2100.arm.linux.org.uk> References: <20140202124358.GD26684@n2100.arm.linux.org.uk> Message-ID: <20140202190606.6fa193ce@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 2 Feb 2014 12:43:58 +0000 Russell King - ARM Linux wrote: > On Wed, Jan 29, 2014 at 10:01:22AM +0100, Jean-Francois Moine wrote: > > This patch set contains various extensions to the tda998x driver: > > > > - simplify the i2c read/write > > - code cleanup and fix some small errors > > - use global constants > > - don't read write-only registers > > - add DT support > > - use IRQ for connection status and EDID read > > I discussed these patches with Rob Clark recently, and the conclusion > we came to is that I'll merge them into a git tree, test them, and > once I'm happy I'll send a pull request as appropriate. > > I'll go through them later today. Those patches which have been re- > posted without any change for the last few times (the first few) I'll > take into my git tree today so you don't have to keep re-posting them > (more importantly, I won't have to keep on looking at them either.) Thanks. BTW, I found some problems with the patch 12 'add DT support' you already acked: - the .of_match_table is not needed because the i2c client is created by the i2c subsystem from the 'reg' in the DT, - on encoder_destroy(), the function drm_i2c_encoder_destroy() unregisters the i2c client, so, with a DT, a second encoder_init() would crash. Do you better like a new patch or a fix? -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/