On Sun, Feb 02, 2014 at 07:06:06PM +0100, Jean-Francois Moine wrote: > - the .of_match_table is not needed because the i2c client is created by > the i2c subsystem from the 'reg' in the DT, It's generally better to have an explict set of OF IDs even if the default does work - matching purely on the device name does work almost all the time but there are collisions out there with different manufacturers using the same prefix for their chips (the example I always trot out is that both Wolfson and Wondermedia use "wm").