From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAfYy-00087J-0P for qemu-devel@nongnu.org; Tue, 04 Feb 2014 07:57:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAfYr-0004Kw-LZ for qemu-devel@nongnu.org; Tue, 04 Feb 2014 07:57:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAfYr-0004Ko-DS for qemu-devel@nongnu.org; Tue, 04 Feb 2014 07:57:09 -0500 Date: Tue, 4 Feb 2014 13:57:07 +0100 From: Kevin Wolf Message-ID: <20140204125707.GH3384@dhcp-200-207.str.redhat.com> References: <1391464280-25627-1-git-send-email-benoit.canet@irqsave.net> <1391464280-25627-2-git-send-email-benoit.canet@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1391464280-25627-2-git-send-email-benoit.canet@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V15 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Am 03.02.2014 um 22:51 hat Beno=EEt Canet geschrieben: > From: Beno=EEt Canet >=20 > Signed-off-by: Benoit Canet > Reviewed-by: Max Reitz > --- > block/Makefile.objs | 1 + > block/quorum.c | 54 +++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 block/quorum.c >=20 > diff --git a/block/Makefile.objs b/block/Makefile.objs > index 4e8c91e..a2650b9 100644 > --- a/block/Makefile.objs > +++ b/block/Makefile.objs > @@ -3,6 +3,7 @@ block-obj-y +=3D qcow2.o qcow2-refcount.o qcow2-cluster= .o qcow2-snapshot.o qcow2-c > block-obj-y +=3D qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-clus= ter.o > block-obj-y +=3D qed-check.o > block-obj-$(CONFIG_VHDX) +=3D vhdx.o vhdx-endian.o vhdx-log.o > +block-obj-y +=3D quorum.o > block-obj-y +=3D parallels.o blkdebug.o blkverify.o > block-obj-y +=3D snapshot.o qapi.o > block-obj-$(CONFIG_WIN32) +=3D raw-win32.o win32-aio.o > diff --git a/block/quorum.c b/block/quorum.c > new file mode 100644 > index 0000000..17695d6 > --- /dev/null > +++ b/block/quorum.c > @@ -0,0 +1,54 @@ > +/* > + * Quorum Block filter > + * > + * Copyright (C) 2012-2014 Nodalink, EURL. > + * > + * Author: > + * Beno=EEt Canet > + * > + * Based on the design and code of blkverify.c (Copyright (C) 2010 IBM= , Corp) > + * and blkmirror.c (Copyright (C) 2011 Red Hat, Inc). I think you were planning to respin anyway, so I'll practice my nitpicking: The file is called mirror.c, not blkmirror.c. > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or = later. > + * See the COPYING file in the top-level directory. > + */ > + > +#include "block/block_int.h" > + > +typedef struct QuorumAIOCB QuorumAIOCB; > + > +/* Quorum will create one instance of the following structure per oper= ation it > + * performs on its children. > + * So for each read/write operation coming from the upper layer there = will be > + * $children_count QuorumSingleAIOCB. > + */ > +typedef struct QuorumSingleAIOCB { > + BlockDriverAIOCB *aiocb; So this isn't a real AIOCB, but it merely points to one. Perhaps something like QuorumChildRequest would be a more precise name? > + QEMUIOVector qiov; > + uint8_t *buf; The combination of a linear buffer and qiov is unusual. It looks like there may be a reason for it (otherwise qemu_iovec_clone() wouldn't exist), but I don't understand it yet at this point. Could hint at a lack of documentation. I might back come to this later in the patch series. > + int ret; > + QuorumAIOCB *parent; > +} QuorumSingleAIOCB; > + > +/* Quorum will use the following structure to track progress of each r= ead/write > + * operation received by the upper layer. > + * This structure hold pointers to the QuorumSingleAIOCB structures in= stances > + * used to do operations on each children and track overall progress. > + */ > +struct QuorumAIOCB { > + BlockDriverAIOCB common; > + > + /* Request metadata */ > + uint64_t sector_num; > + int nb_sectors; > + > + QEMUIOVector *qiov; /* calling IOV */ > + > + QuorumSingleAIOCB *aios; /* individual AIOs */ > + int count; /* number of completed AIOCB */ > + int success_count; /* number of successfully completed AI= OCB */ > + bool *finished; /* completion signal for cancel */ > + > + bool is_read; > + int vote_ret; > +}; Kevin