From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2 08/11] of: Increase MAX_PHANDLE_ARGS Date: Tue, 04 Feb 2014 17:36:47 +0000 Message-ID: <20140204173647.4B0D6C40B12@trevor.secretlab.ca> References: <1389876263-25759-1-git-send-email-andreas.herrmann@calxeda.com> <1389876263-25759-9-git-send-email-andreas.herrmann@calxeda.com> < 20140117110830.GW3471@alberich> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140117110830.GW3471@alberich> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Andreas Herrmann , Will Deacon Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Rob Herring , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Fri, 17 Jan 2014 12:08:30 +0100, Andreas Herrmann wrote: > > arm-smmu driver uses of_parse_phandle_with_args when parsing DT > information to determine stream IDs for a master device. > Thus the number of stream IDs per master device is bound by > MAX_PHANDLE_ARGS. > > To support Calxeda ECX-2000 hardware arm-smmu driver requires a > slightly higher value for MAX_PHANDLE_ARGS as this hardware has 10 > stream IDs for one master device. > > Increasing it to 16 seems a reasonable choice. > > Cc: Grant Likely > Cc: Rob Herring > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Andreas Herrmann > Acked-by: Rob Herring > Signed-off-by: Andreas Herrmann I've merged this one, but I'm not excited about making it any larger because this structure lives on the stack most of the time. g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@linaro.org (Grant Likely) Date: Tue, 04 Feb 2014 17:36:47 +0000 Subject: [PATCH v2 08/11] of: Increase MAX_PHANDLE_ARGS In-Reply-To: <20140117110830.GW3471@alberich> References: <1389876263-25759-1-git-send-email-andreas.herrmann@calxeda.com> <1389876263-25759-9-git-send-email-andreas.herrmann@calxeda.com> < 20140117110830.GW3471@alberich> Message-ID: <20140204173647.4B0D6C40B12@trevor.secretlab.ca> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 17 Jan 2014 12:08:30 +0100, Andreas Herrmann wrote: > > arm-smmu driver uses of_parse_phandle_with_args when parsing DT > information to determine stream IDs for a master device. > Thus the number of stream IDs per master device is bound by > MAX_PHANDLE_ARGS. > > To support Calxeda ECX-2000 hardware arm-smmu driver requires a > slightly higher value for MAX_PHANDLE_ARGS as this hardware has 10 > stream IDs for one master device. > > Increasing it to 16 seems a reasonable choice. > > Cc: Grant Likely > Cc: Rob Herring > Cc: devicetree at vger.kernel.org > Cc: Andreas Herrmann > Acked-by: Rob Herring > Signed-off-by: Andreas Herrmann I've merged this one, but I'm not excited about making it any larger because this structure lives on the stack most of the time. g.