From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Martin Öhrling" <xen@xn--hrling-vxa.se>, linux@eikelenboom.it
Cc: xen-devel@lists.xen.org
Subject: Re: Inconsistent use of libxl__device_pci_reset() when adding/removing all functions of a device
Date: Tue, 4 Feb 2014 14:55:51 -0500 [thread overview]
Message-ID: <20140204195551.GA14122@phenom.dumpdata.com> (raw)
In-Reply-To: <CABg547VOFCYPiENWX7EBuoou1A2=wV7_TYjFA+-1FjiQ=PVHfw@mail.gmail.com>
On Tue, Feb 04, 2014 at 07:19:16PM +0100, Martin Öhrling wrote:
> I tried to use vga passthrough with an AMD card and ran into the issues
> with dom0 crash on domU reboot. My intention is to debug the issue and I
> have started to read up on the code for pci passthrough. The following
> observations may not be an error but perhaps someone could shed some light
> over the design intentions.
>
> My first impression was that libxl__device_pci_reset() is a function level
> reset function. It is called each time a single function of a device is
> added or removed. A device reset would break other domU:s if other
> functions of the device are passed through to these domU:s.
>
> The strange thing is that there is only a single libxl__device_pci_reset()
> call when pcidev->vfunc_mask is set to LIBXL_PCI_FUNC_ALL. I'm getting the
> impression that the function is assumed to be a device reset function.
>
> Is the attempt to reset a function, when all other functions belongs to
> pciback, detected and replaced by a device reset?
Yes with these patches:
https://git.kernel.org/cgit/linux/kernel/git/konrad/xen.git/log/?h=devel/xen-pciback.slot_and_bus.v0
But the last one seems to hang pciback when the device is unbound.
>
> Best Regards,
> Martin
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-02-04 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 18:19 Inconsistent use of libxl__device_pci_reset() when adding/removing all functions of a device Martin Öhrling
2014-02-04 19:55 ` Konrad Rzeszutek Wilk [this message]
2014-02-04 20:05 ` Sander Eikelenboom
2014-02-25 11:31 ` Martin Öhrling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204195551.GA14122@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=linux@eikelenboom.it \
--cc=xen-devel@lists.xen.org \
--cc=xen@xn--hrling-vxa.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.