From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755022AbaBECDA (ORCPT ); Tue, 4 Feb 2014 21:03:00 -0500 Received: from zene.cmpxchg.org ([85.214.230.12]:57453 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbaBECC7 (ORCPT ); Tue, 4 Feb 2014 21:02:59 -0500 Date: Tue, 4 Feb 2014 21:02:22 -0500 From: Johannes Weiner To: Andrew Morton Cc: Andi Kleen , Andrea Arcangeli , Bob Liu , Christoph Hellwig , Dave Chinner , Greg Thelen , Hugh Dickins , Jan Kara , KOSAKI Motohiro , Luigi Semenzato , Mel Gorman , Metin Doslu , Michel Lespinasse , Minchan Kim , Ozgun Erdogan , Peter Zijlstra , Rik van Riel , Roman Gushchin , Ryan Mallon , Tejun Heo , Vlastimil Babka , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 00/10] mm: thrash detection-based file cache sizing v9 Message-ID: <20140205020222.GX6963@cmpxchg.org> References: <1391475222-1169-1-git-send-email-hannes@cmpxchg.org> <20140204151424.d08301233c1f1801f43498b1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140204151424.d08301233c1f1801f43498b1@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 04, 2014 at 03:14:24PM -0800, Andrew Morton wrote: > On Mon, 3 Feb 2014 19:53:32 -0500 Johannes Weiner wrote: > > > o Fix vmstat build problems on UP (Fengguang Wu's build bot) > > > > o Clarify why optimistic radix_tree_node->private_list link checking > > is safe without holding the list_lru lock (Dave Chinner) > > > > o Assert locking balance when the list_lru isolator says it dropped > > the list lock (Dave Chinner) > > > > o Remove remnant of a manual reclaim counter in the shadow isolator, > > the list_lru-provided accounting is accurate now that we added > > LRU_REMOVED_RETRY (Dave Chinner) > > > > o Set an object limit for the shadow shrinker instead of messing with > > its seeks setting. The configured seeks define how pressure applied > > to pages translates to pressure on the object pool, in itself it is > > not enough to replace proper object valuation to classify expired > > and in-use objects. Shadow nodes contain up to 64 shadow entries > > from different/alternating zones that have their own atomic age > > counter, so determining if a node is overall expired is crazy > > expensive. Instead, use an object limit above which nodes are very > > likely to be expired. > > > > o __pagevec_lookup and __find_get_pages kerneldoc fixes (Minchan Kim) > > > > o radix_tree_node->count accessors for pages and shadows (Minchan Kim) > > > > o Rebase to v3.14-rc1 and add review tags > > An earlier version caused a 24-byte inode bloatage. That appears to > have been reduced to 8 bytes, yes? What was done there? Instead of inodes, the shrinker now directly tracks radix tree nodes that contain only shadow entries. So the 16 bytes for the list_head are now in struct radix_tree_node, but due to different slab packing it didn't increase memory consumption. > > 69 files changed, 1438 insertions(+), 462 deletions(-) > > omigod Most of it is comments and Minchan's accessor functions. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [patch 00/10] mm: thrash detection-based file cache sizing v9 Date: Tue, 4 Feb 2014 21:02:22 -0500 Message-ID: <20140205020222.GX6963@cmpxchg.org> References: <1391475222-1169-1-git-send-email-hannes@cmpxchg.org> <20140204151424.d08301233c1f1801f43498b1@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andi Kleen , Andrea Arcangeli , Bob Liu , Christoph Hellwig , Dave Chinner , Greg Thelen , Hugh Dickins , Jan Kara , KOSAKI Motohiro , Luigi Semenzato , Mel Gorman , Metin Doslu , Michel Lespinasse , Minchan Kim , Ozgun Erdogan , Peter Zijlstra , Rik van Riel , Roman Gushchin , Ryan Mallon , Tejun Heo , Vlastimil Babka , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Andrew Morton Return-path: Content-Disposition: inline In-Reply-To: <20140204151424.d08301233c1f1801f43498b1@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Feb 04, 2014 at 03:14:24PM -0800, Andrew Morton wrote: > On Mon, 3 Feb 2014 19:53:32 -0500 Johannes Weiner wrote: > > > o Fix vmstat build problems on UP (Fengguang Wu's build bot) > > > > o Clarify why optimistic radix_tree_node->private_list link checking > > is safe without holding the list_lru lock (Dave Chinner) > > > > o Assert locking balance when the list_lru isolator says it dropped > > the list lock (Dave Chinner) > > > > o Remove remnant of a manual reclaim counter in the shadow isolator, > > the list_lru-provided accounting is accurate now that we added > > LRU_REMOVED_RETRY (Dave Chinner) > > > > o Set an object limit for the shadow shrinker instead of messing with > > its seeks setting. The configured seeks define how pressure applied > > to pages translates to pressure on the object pool, in itself it is > > not enough to replace proper object valuation to classify expired > > and in-use objects. Shadow nodes contain up to 64 shadow entries > > from different/alternating zones that have their own atomic age > > counter, so determining if a node is overall expired is crazy > > expensive. Instead, use an object limit above which nodes are very > > likely to be expired. > > > > o __pagevec_lookup and __find_get_pages kerneldoc fixes (Minchan Kim) > > > > o radix_tree_node->count accessors for pages and shadows (Minchan Kim) > > > > o Rebase to v3.14-rc1 and add review tags > > An earlier version caused a 24-byte inode bloatage. That appears to > have been reduced to 8 bytes, yes? What was done there? Instead of inodes, the shrinker now directly tracks radix tree nodes that contain only shadow entries. So the 16 bytes for the list_head are now in struct radix_tree_node, but due to different slab packing it didn't increase memory consumption. > > 69 files changed, 1438 insertions(+), 462 deletions(-) > > omigod Most of it is comments and Minchan's accessor functions. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org