From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: function snprintf() in xen_save_domain.c for
	debugged
Date: Wed, 5 Feb 2014 13:39:08 +0100
Message-ID: <20140205123908.GA1198@aepfle.de>
References: <1391331061.24599.YahooMailNeo@web161802.mail.bf1.yahoo.com>
	<20140202100044.GA5898@aepfle.de>
	<1391432170.33697.YahooMailNeo@web161806.mail.bf1.yahoo.com>
	<20140203131144.GA31275@aepfle.de>
	<1391583040.24823.YahooMailNeo@web161802.mail.bf1.yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1391583040.24823.YahooMailNeo@web161802.mail.bf1.yahoo.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Adel Amani <adel.amani66@yahoo.com>
Cc: Xen <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, Feb 04, Adel Amani wrote:

>     si.flags = atoi(argv[5]);

> lvl = si.flags & XCFLAGS_DEBUG ? XTL_DEBUG: XTL_DETAIL;
> lflags = XTL_STDIOSTREAM_SHOW_PID | XTL_STDIOSTREAM_HIDE_PROGRESS;
> l = (xentoollog_logger *)xtl_createlogger_stdiostream(stderr, lvl, lflags);
> si.xch = xc_interface_open(l,0,0);

Please check what XCFLAGS_DEBUG actually means, and if that condition
can ever be true without modifying also xend related code.

I guess in your exploration of how migration internally actually works
it would be easier for you to just write 'lvl = XTL_DEBUG;' and be done
with it.

Other than that, the changes you made appear to be correct.

Olaf