From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] [RFC] drm/i915: Generate a hang error code Date: Wed, 5 Feb 2014 14:59:08 +0000 Message-ID: <20140205145908.50978978@jbarnes-t420> References: <1391516335-2723-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from alt-proxy54.mail.unifiedlayer.com (alt-proxy54.mail.unifiedlayer.com [69.195.73.6]) by gabe.freedesktop.org (Postfix) with SMTP id 6A6EA106EE8 for ; Wed, 5 Feb 2014 07:06:14 -0800 (PST) In-Reply-To: <1391516335-2723-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, 4 Feb 2014 12:18:55 +0000 Ben Widawsky wrote: > We get a large number of bugs which have a, "hey I have that too" > because they see a GPU hang in dmesg. While two machines of the same > model having a GPU hang is indeed a coincidence, it is far from enough > evidence to suggest they are the same. > > In order to reduce this effect, and hopefully get people to file new bug > reports, clearly the error message itself has been insufficient (see ref > at the bottom for a new bug report with this characteristic). > > The algorithm is purposely pretty naive. I don't think we need much in > order to avoid the problem I am trying to solve, and keeping it naive > gives us some ability to make a decent test case. I like the direction of this. If we can get some basic info into the dmesg part of things (the only part regular users will actually look at) we can probably avoid some of the "me too" action we see on general GPU hangs. Having PID, comm, and some sort of hang signature are all good steps in that direction imo. Acked-by: Jesse Barnes Jesse