All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] gpio: Driver for SYSCON-based GPIOs
@ 2014-01-13 16:56 Alexander Shiyan
  2014-01-30 13:54 ` Linus Walleij
  0 siblings, 1 reply; 10+ messages in thread
From: Alexander Shiyan @ 2014-01-13 16:56 UTC (permalink / raw)
  To: linux-gpio-u79uwXL29TY76Z2rM5mHXA
  Cc: Linus Walleij, Alexandre Courbot, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Alexander Shiyan

SYSCON driver was designed for using memory areas (registers)
that are used in several subsystems. There are systems (CPUs)
which use bits in one register for various purposes and thus
should be handled by various kernel subsystems. This driver
allows you to use the individual SYSCON bits as GPIOs.
ARM CLPS711X SYSFLG1 input lines has been added as first user
of this driver.

Signed-off-by: Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
---
 .../devicetree/bindings/gpio/gpio-syscon.txt       |  19 +++
 drivers/gpio/Kconfig                               |   6 +
 drivers/gpio/Makefile                              |   1 +
 drivers/gpio/gpio-syscon.c                         | 187 +++++++++++++++++++++
 4 files changed, 213 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-syscon.txt
 create mode 100644 drivers/gpio/gpio-syscon.c

diff --git a/Documentation/devicetree/bindings/gpio/gpio-syscon.txt b/Documentation/devicetree/bindings/gpio/gpio-syscon.txt
new file mode 100644
index 0000000..cad764a
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-syscon.txt
@@ -0,0 +1,19 @@
+* SYSCON-based GPIO driver
+
+Required properties:
+- compatible: Should contain one of the following:
+  - "cirrus,clps711x-mctrl": For ARM CLPS711X SYSFLG1 MCTRL GPIOs.
+- syscon: phandle to syscon device node.
+- gpio-controller: Marks the device node as a gpio controller.
+- #gpio-cells: Should be two. The first cell is the pin number and
+  the second cell is used to specify the gpio polarity:
+    0 = Active high,
+    1 = Active low.
+
+Example:
+	sysgpio: sysgpio {
+		compatible = "cirrus,clps711x-mctrl";
+		syscon = <&syscon1>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 8c0df49..1f34bdc 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -275,6 +275,12 @@ config GPIO_STA2X11
 	  Say yes here to support the STA2x11/ConneXt GPIO device.
 	  The GPIO module has 128 GPIO pins with alternate functions.
 
+config GPIO_SYSCON
+	tristate "GPIO based on SYSCON"
+	depends on MFD_SYSCON && OF
+	help
+	  Say yes here to support GPIO functionality though SYSCON driver.
+
 config GPIO_TS5500
 	tristate "TS-5500 DIO blocks and compatibles"
 	help
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index 5d50179..8ae6d47 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -76,6 +76,7 @@ obj-$(CONFIG_GPIO_STA2X11)	+= gpio-sta2x11.o
 obj-$(CONFIG_GPIO_STMPE)	+= gpio-stmpe.o
 obj-$(CONFIG_GPIO_STP_XWAY)	+= gpio-stp-xway.o
 obj-$(CONFIG_GPIO_SX150X)	+= gpio-sx150x.o
+obj-$(CONFIG_GPIO_SYSCON)	+= gpio-syscon.o
 obj-$(CONFIG_GPIO_TB10X)	+= gpio-tb10x.o
 obj-$(CONFIG_GPIO_TC3589X)	+= gpio-tc3589x.o
 obj-$(CONFIG_ARCH_TEGRA)	+= gpio-tegra.o
diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c
new file mode 100644
index 0000000..9f6f0f8
--- /dev/null
+++ b/drivers/gpio/gpio-syscon.c
@@ -0,0 +1,187 @@
+/*
+ *  SYSCON GPIO driver
+ *
+ *  Copyright (C) 2014 Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <linux/err.h>
+#include <linux/gpio.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/mfd/syscon.h>
+
+#define GPIO_SYSCON_FEAT_IN	BIT(0)
+#define GPIO_SYSCON_FEAT_OUT	BIT(1)
+#define GPIO_SYSCON_FEAT_DIR	BIT(2)
+
+/* SYSCON driver is designed to use 32-bit wide registers */
+#define SYSCON_REG_SIZE		(4)
+#define SYSCON_REG_BITS		(SYSCON_REG_SIZE * 8)
+
+/**
+ * struct syscon_gpio_data - Configuration for the device.
+ * flags:		Set of GPIO_SYSCON_FEAT_ flags:
+ *			GPIO_SYSCON_FEAT_IN:	GPIOs supports input,
+ *			GPIO_SYSCON_FEAT_OUT:	GPIOs supports output,
+ *			GPIO_SYSCON_FEAT_DIR:	GPIOs supports switch direction.
+ * bit_count:		Number of bits used as GPIOs.
+ * dat_bit_offset:	Offset (in bits) to the first GPIO bit.
+ * dir_bit_offset:	Optional offset (in bits) to the first bit to switch
+ *			GPIO direction (Used with GPIO_SYSCON_FEAT_DIR flag).
+ */
+
+struct syscon_gpio_data {
+	unsigned int	flags;
+	unsigned int	bit_count;
+	unsigned int	dat_bit_offset;
+	unsigned int	dir_bit_offset;
+};
+
+struct syscon_gpio_priv {
+	struct gpio_chip		chip;
+	struct regmap			*syscon;
+	const struct syscon_gpio_data	*data;
+};
+
+static inline struct syscon_gpio_priv *to_syscon_gpio(struct gpio_chip *chip)
+{
+	return container_of(chip, struct syscon_gpio_priv, chip);
+}
+
+static int syscon_gpio_get(struct gpio_chip *chip, unsigned offset)
+{
+	struct syscon_gpio_priv *priv = to_syscon_gpio(chip);
+	unsigned int val, offs = priv->data->dat_bit_offset + offset;
+	int ret;
+
+	ret = regmap_read(priv->syscon,
+			  (offs / SYSCON_REG_BITS) * SYSCON_REG_SIZE, &val);
+	if (ret)
+		return ret;
+
+	return !!(val & BIT(offs % SYSCON_REG_BITS));
+}
+
+static void syscon_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
+{
+	struct syscon_gpio_priv *priv = to_syscon_gpio(chip);
+	unsigned int offs = priv->data->dat_bit_offset + offset;
+
+	regmap_update_bits(priv->syscon,
+			   (offs / SYSCON_REG_BITS) * SYSCON_REG_SIZE,
+			   BIT(offs % SYSCON_REG_BITS),
+			   val ? BIT(offs % SYSCON_REG_BITS) : 0);
+}
+
+static int syscon_gpio_dir_in(struct gpio_chip *chip, unsigned offset)
+{
+	struct syscon_gpio_priv *priv = to_syscon_gpio(chip);
+
+	if (priv->data->flags & GPIO_SYSCON_FEAT_DIR) {
+		unsigned int offs = priv->data->dir_bit_offset + offset;
+
+		regmap_update_bits(priv->syscon,
+				   (offs / SYSCON_REG_BITS) * SYSCON_REG_SIZE,
+				   BIT(offs % SYSCON_REG_BITS), 0);
+	}
+
+	return 0;
+}
+
+static int syscon_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int val)
+{
+	struct syscon_gpio_priv *priv = to_syscon_gpio(chip);
+
+	if (priv->data->flags & GPIO_SYSCON_FEAT_DIR) {
+		unsigned int offs = priv->data->dir_bit_offset + offset;
+
+		regmap_update_bits(priv->syscon,
+				   (offs / SYSCON_REG_BITS) * SYSCON_REG_SIZE,
+				   BIT(offs % SYSCON_REG_BITS),
+				   BIT(offs % SYSCON_REG_BITS));
+	}
+
+	syscon_gpio_set(chip, offset, val);
+
+	return 0;
+}
+
+static const struct syscon_gpio_data clps711x_mctrl_gpio = {
+	/* ARM CLPS711X SYSFLG1 Bits 8-10 */
+	.flags		= GPIO_SYSCON_FEAT_IN,
+	.bit_count	= 3,
+	.dat_bit_offset	= 0x40 * 8 + 8,
+};
+
+static const struct of_device_id syscon_gpio_ids[] = {
+	{
+		.compatible	= "cirrus,clps711x-mctrl",
+		.data		= &clps711x_mctrl_gpio,
+	},
+	{ }
+};
+MODULE_DEVICE_TABLE(of, syscon_gpio_ids);
+
+static int syscon_gpio_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	const struct of_device_id *of_id = of_match_device(syscon_gpio_ids, dev);
+	struct syscon_gpio_priv *priv;
+
+	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+	if (!priv)
+		return -ENOMEM;
+
+	priv->syscon = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon");
+	if (IS_ERR(priv->syscon))
+		return PTR_ERR(priv->syscon);
+
+	priv->data = of_id->data;
+
+	priv->chip.dev = dev;
+	priv->chip.owner = THIS_MODULE;
+	priv->chip.label = dev_name(dev);
+	priv->chip.base = -1;
+	priv->chip.ngpio = priv->data->bit_count;
+	priv->chip.get = syscon_gpio_get;
+	if (priv->data->flags & GPIO_SYSCON_FEAT_IN)
+		priv->chip.direction_input = syscon_gpio_dir_in;
+	if (priv->data->flags & GPIO_SYSCON_FEAT_OUT) {
+		priv->chip.set = syscon_gpio_set;
+		priv->chip.direction_output = syscon_gpio_dir_out;
+	}
+
+	platform_set_drvdata(pdev, priv);
+
+	return gpiochip_add(&priv->chip);
+}
+
+static int syscon_gpio_remove(struct platform_device *pdev)
+{
+	struct syscon_gpio_priv *priv = platform_get_drvdata(pdev);
+
+	return gpiochip_remove(&priv->chip);
+}
+
+static struct platform_driver syscon_gpio_driver = {
+	.driver	= {
+		.name		= "gpio-syscon",
+		.owner		= THIS_MODULE,
+		.of_match_table	= syscon_gpio_ids,
+	},
+	.probe	= syscon_gpio_probe,
+	.remove	= syscon_gpio_remove,
+};
+module_platform_driver(syscon_gpio_driver);
+
+MODULE_AUTHOR("Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>");
+MODULE_DESCRIPTION("SYSCON GPIO driver");
+MODULE_LICENSE("GPL");
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
  2014-01-13 16:56 [PATCH v4] gpio: Driver for SYSCON-based GPIOs Alexander Shiyan
@ 2014-01-30 13:54 ` Linus Walleij
       [not found]   ` <CACRpkdaVn0iNFYKE3HXWxnb4iCJorF0HSVG4Uvz8Q18SiF5PUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
                     ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Linus Walleij @ 2014-01-30 13:54 UTC (permalink / raw)
  To: Alexander Shiyan, Arnd Bergmann, Olof Johansson, Kevin Hilman
  Cc: linux-gpio, Alexandre Courbot, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, devicetree

On Mon, Jan 13, 2014 at 5:56 PM, Alexander Shiyan <shc_work@mail.ru> wrote:

> SYSCON driver was designed for using memory areas (registers)
> that are used in several subsystems. There are systems (CPUs)
> which use bits in one register for various purposes and thus
> should be handled by various kernel subsystems. This driver
> allows you to use the individual SYSCON bits as GPIOs.
> ARM CLPS711X SYSFLG1 input lines has been added as first user
> of this driver.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Oh the pain. I am so ambivalent of this patch as it obfuscates
some stuff about the hardware that the driver should know,
while at the same time being elegant in a way.

What does the ARM SoC maintainers think about this approach?

Arnd, Olof, Kevin: is this something you'd like to see deployed?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
       [not found]   ` <CACRpkdaVn0iNFYKE3HXWxnb4iCJorF0HSVG4Uvz8Q18SiF5PUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-02-05 16:08     ` Alexander Shiyan
  0 siblings, 0 replies; 10+ messages in thread
From: Alexander Shiyan @ 2014-02-05 16:08 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Arnd Bergmann, Olof Johansson, Kevin Hilman,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA, Alexandre Courbot,
	Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	devicetree-u79uwXL29TY76Z2rM5mHXA

On Thu, 30 Jan 2014 14:54:36 +0100
Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:

> On Mon, Jan 13, 2014 at 5:56 PM, Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org> wrote:
> 
> > SYSCON driver was designed for using memory areas (registers)
> > that are used in several subsystems. There are systems (CPUs)
> > which use bits in one register for various purposes and thus
> > should be handled by various kernel subsystems. This driver
> > allows you to use the individual SYSCON bits as GPIOs.
> > ARM CLPS711X SYSFLG1 input lines has been added as first user
> > of this driver.
> >
> > Signed-off-by: Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
> 
> Oh the pain. I am so ambivalent of this patch as it obfuscates
> some stuff about the hardware that the driver should know,
> while at the same time being elegant in a way.
> 
> What does the ARM SoC maintainers think about this approach?
> 
> Arnd, Olof, Kevin: is this something you'd like to see deployed?

Ping.

-- 
Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
  2014-01-30 13:54 ` Linus Walleij
       [not found]   ` <CACRpkdaVn0iNFYKE3HXWxnb4iCJorF0HSVG4Uvz8Q18SiF5PUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-02-18 14:46   ` Alexander Shiyan
  2014-02-18 23:25   ` Olof Johansson
  2 siblings, 0 replies; 10+ messages in thread
From: Alexander Shiyan @ 2014-02-18 14:46 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Arnd Bergmann, Olof Johansson, Kevin Hilman, linux-gpio,
	Alexandre Courbot, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree

On Thu, 30 Jan 2014 14:54:36 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Mon, Jan 13, 2014 at 5:56 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> 
> > SYSCON driver was designed for using memory areas (registers)
> > that are used in several subsystems. There are systems (CPUs)
> > which use bits in one register for various purposes and thus
> > should be handled by various kernel subsystems. This driver
> > allows you to use the individual SYSCON bits as GPIOs.
> > ARM CLPS711X SYSFLG1 input lines has been added as first user
> > of this driver.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> 
> Oh the pain. I am so ambivalent of this patch as it obfuscates
> some stuff about the hardware that the driver should know,
> while at the same time being elegant in a way.
> 
> What does the ARM SoC maintainers think about this approach?
> 
> Arnd, Olof, Kevin: is this something you'd like to see deployed?
> 
> Yours,
> Linus Walleij

Ping.

-- 
Alexander Shiyan <shc_work@mail.ru>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
  2014-01-30 13:54 ` Linus Walleij
       [not found]   ` <CACRpkdaVn0iNFYKE3HXWxnb4iCJorF0HSVG4Uvz8Q18SiF5PUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  2014-02-18 14:46   ` Alexander Shiyan
@ 2014-02-18 23:25   ` Olof Johansson
  2014-02-25 15:09     ` Alexander Shiyan
  2 siblings, 1 reply; 10+ messages in thread
From: Olof Johansson @ 2014-02-18 23:25 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Alexander Shiyan, Arnd Bergmann, Kevin Hilman, linux-gpio,
	Alexandre Courbot, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, devicetree

On Thu, Jan 30, 2014 at 02:54:36PM +0100, Linus Walleij wrote:
> On Mon, Jan 13, 2014 at 5:56 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> 
> > SYSCON driver was designed for using memory areas (registers)
> > that are used in several subsystems. There are systems (CPUs)
> > which use bits in one register for various purposes and thus
> > should be handled by various kernel subsystems. This driver
> > allows you to use the individual SYSCON bits as GPIOs.
> > ARM CLPS711X SYSFLG1 input lines has been added as first user
> > of this driver.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> 
> Oh the pain. I am so ambivalent of this patch as it obfuscates
> some stuff about the hardware that the driver should know,
> while at the same time being elegant in a way.
> 
> What does the ARM SoC maintainers think about this approach?
> 
> Arnd, Olof, Kevin: is this something you'd like to see deployed?

I think the binding needs to be adjusted -- syscon has nothing to do with
the binding, that's a Linux construct.

Really, if this is rephrased it becomes much more clear that this is a useful
driver:

CLPS711X implements a few GPIO lines in a register area that is shared with
other system registers. This is a driver for those GPIO lines, implemented
using the shared syscon infrastructure in the kernel.

And then take out syscon from the name of the driver (and the binding).

If we have more drivers like these down the road we can make a common shared
binding, but until then I don't think there's much point in it.


-Olof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
  2014-02-18 23:25   ` Olof Johansson
@ 2014-02-25 15:09     ` Alexander Shiyan
  2014-03-05  1:11       ` Linus Walleij
  0 siblings, 1 reply; 10+ messages in thread
From: Alexander Shiyan @ 2014-02-25 15:09 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Linus Walleij, Arnd Bergmann, Kevin Hilman, linux-gpio,
	Alexandre Courbot

On Tue, 18 Feb 2014 15:25:20 -0800
Olof Johansson <olof@lixom.net> wrote:

> On Thu, Jan 30, 2014 at 02:54:36PM +0100, Linus Walleij wrote:
> > On Mon, Jan 13, 2014 at 5:56 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> > 
> > > SYSCON driver was designed for using memory areas (registers)
> > > that are used in several subsystems. There are systems (CPUs)
> > > which use bits in one register for various purposes and thus
> > > should be handled by various kernel subsystems. This driver
> > > allows you to use the individual SYSCON bits as GPIOs.
> > > ARM CLPS711X SYSFLG1 input lines has been added as first user
> > > of this driver.
> > >
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > 
> > Oh the pain. I am so ambivalent of this patch as it obfuscates
> > some stuff about the hardware that the driver should know,
> > while at the same time being elegant in a way.
> > 
> > What does the ARM SoC maintainers think about this approach?
> > 
> > Arnd, Olof, Kevin: is this something you'd like to see deployed?
> 
> I think the binding needs to be adjusted -- syscon has nothing to do with
> the binding, that's a Linux construct.
> 
> Really, if this is rephrased it becomes much more clear that this is a useful
> driver:
> 
> CLPS711X implements a few GPIO lines in a register area that is shared with
> other system registers. This is a driver for those GPIO lines, implemented
> using the shared syscon infrastructure in the kernel.
> 
> And then take out syscon from the name of the driver (and the binding).
> 
> If we have more drivers like these down the road we can make a common shared
> binding, but until then I don't think there's much point in it.

Is this proposed to remove the generic implementation?
Linus, what is your opinion on this?

-- 
Alexander Shiyan <shc_work@mail.ru>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
  2014-02-25 15:09     ` Alexander Shiyan
@ 2014-03-05  1:11       ` Linus Walleij
  2014-03-05  7:03         ` Alexander Shiyan
  0 siblings, 1 reply; 10+ messages in thread
From: Linus Walleij @ 2014-03-05  1:11 UTC (permalink / raw)
  To: Alexander Shiyan
  Cc: Olof Johansson, Arnd Bergmann, Kevin Hilman, linux-gpio,
	Alexandre Courbot

On Tue, Feb 25, 2014 at 11:09 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> On Tue, 18 Feb 2014 15:25:20 -0800
> Olof Johansson <olof@lixom.net> wrote:

>> If we have more drivers like these down the road we can make a common shared
>> binding, but until then I don't think there's much point in it.
>
> Is this proposed to remove the generic implementation?
> Linus, what is your opinion on this?

That is better, because it relieves me from the pain about this
driver. (Sorry for slow answers.)

So instead of this:

+- compatible: Should contain one of the following:
+  - "clps711x,syscon-gpio-mctrl": For ARM CLPS711X SYSFLG1 MCTRL GPIOs.

Something more like

"cirrus,clps711x-syscon-gpio"

I guess?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
  2014-03-05  1:11       ` Linus Walleij
@ 2014-03-05  7:03         ` Alexander Shiyan
  2014-03-07  3:46           ` Linus Walleij
  0 siblings, 1 reply; 10+ messages in thread
From: Alexander Shiyan @ 2014-03-05  7:03 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Olof Johansson, Arnd Bergmann, Kevin Hilman, linux-gpio,
	Alexandre Courbot

Среда,  5 марта 2014, 9:11 +08:00 от Linus Walleij <linus.walleij@linaro.org>:
> On Tue, Feb 25, 2014 at 11:09 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> > On Tue, 18 Feb 2014 15:25:20 -0800
> > Olof Johansson <olof@lixom.net> wrote:
> 
> >> If we have more drivers like these down the road we can make a common shared
> >> binding, but until then I don't think there's much point in it.
> >
> > Is this proposed to remove the generic implementation?
> > Linus, what is your opinion on this?
> 
> That is better, because it relieves me from the pain about this
> driver. (Sorry for slow answers.)
> 
> So instead of this:
> 
> +- compatible: Should contain one of the following:
> +  - "clps711x,syscon-gpio-mctrl": For ARM CLPS711X SYSFLG1 MCTRL GPIOs.
> 
> Something more like
> 
> "cirrus,clps711x-syscon-gpio"
> 
> I guess?

I think that Olof meant to completely remove the concept of "syscon" from the
DT description.
This can be done by changing the compatibility string with "cirrus,clps711x-mctrl-gpio"
for my case and hide "syscon" in the internal structure of the driver to use the
syscon_regmap_lookup_by_compatible() function.
If so, then I'll make the next version.

---

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
  2014-03-05  7:03         ` Alexander Shiyan
@ 2014-03-07  3:46           ` Linus Walleij
  2014-03-09  5:01             ` Olof Johansson
  0 siblings, 1 reply; 10+ messages in thread
From: Linus Walleij @ 2014-03-07  3:46 UTC (permalink / raw)
  To: Alexander Shiyan
  Cc: Olof Johansson, Arnd Bergmann, Kevin Hilman, linux-gpio,
	Alexandre Courbot

On Wed, Mar 5, 2014 at 3:03 PM, Alexander Shiyan <shc_work@mail.ru> wrote:

> I think that Olof meant to completely remove the concept of "syscon" from the
> DT description.
> This can be done by changing the compatibility string with "cirrus,clps711x-mctrl-gpio"
> for my case and hide "syscon" in the internal structure of the driver to use the
> syscon_regmap_lookup_by_compatible() function.
> If so, then I'll make the next version.

OK sounds like a plan.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] gpio: Driver for SYSCON-based GPIOs
  2014-03-07  3:46           ` Linus Walleij
@ 2014-03-09  5:01             ` Olof Johansson
  0 siblings, 0 replies; 10+ messages in thread
From: Olof Johansson @ 2014-03-09  5:01 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Alexander Shiyan, Arnd Bergmann, Kevin Hilman, linux-gpio,
	Alexandre Courbot

On Fri, Mar 07, 2014 at 11:46:13AM +0800, Linus Walleij wrote:
> On Wed, Mar 5, 2014 at 3:03 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> 
> > I think that Olof meant to completely remove the concept of "syscon" from the
> > DT description.
> > This can be done by changing the compatibility string with "cirrus,clps711x-mctrl-gpio"
> > for my case and hide "syscon" in the internal structure of the driver to use the
> > syscon_regmap_lookup_by_compatible() function.
> > If so, then I'll make the next version.
> 
> OK sounds like a plan.

Yep, agreed. Syscon as a term is a linux-side construct, and not something we
should necessarily have carry over in mindings and DT names.


-Olof

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2014-03-09  5:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-13 16:56 [PATCH v4] gpio: Driver for SYSCON-based GPIOs Alexander Shiyan
2014-01-30 13:54 ` Linus Walleij
     [not found]   ` <CACRpkdaVn0iNFYKE3HXWxnb4iCJorF0HSVG4Uvz8Q18SiF5PUQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-05 16:08     ` Alexander Shiyan
2014-02-18 14:46   ` Alexander Shiyan
2014-02-18 23:25   ` Olof Johansson
2014-02-25 15:09     ` Alexander Shiyan
2014-03-05  1:11       ` Linus Walleij
2014-03-05  7:03         ` Alexander Shiyan
2014-03-07  3:46           ` Linus Walleij
2014-03-09  5:01             ` Olof Johansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.