From: Chris Wilson <chris@chris-wilson.co.uk>
To: akash.goel@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation
Date: Fri, 7 Feb 2014 12:31:28 +0000 [thread overview]
Message-ID: <20140207123128.GJ5360@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1391775732-7431-4-git-send-email-akash.goel@intel.com>
On Fri, Feb 07, 2014 at 05:52:12PM +0530, akash.goel@intel.com wrote:
> From: Akash Goel <akash.goel@intel.com>
>
> Modified programming of following 2 regs in Render ring initialisation fn.
> 1. GFX_MODE_GEN7 (Enabling TLB invalidate)
The changelog needs to explain why. According to the spec this is a
pessimisation.
> 2. MI_MODE (Enabling MI Flush)
And this is out-of-date. Doesn't describe the actual change nor why.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2014-02-07 12:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 12:22 [PATCH v2 0/3] Rendering specific Hw workarounds for VLV akash.goel
2014-02-07 12:22 ` [PATCH v2 1/3] drm/i915/vlv: Added a rendering specific Hw WA 'WaTlbInvalidateStoreDataBefore' akash.goel
2014-03-21 11:50 ` Gupta, Sourab
2014-03-21 11:59 ` Damien Lespiau
2014-02-07 12:22 ` [PATCH v2 2/3] drm/i915/vlv: Added a rendering specific Hw WA 'WaReadAfterWriteHazard' akash.goel
2014-02-07 12:22 ` [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation akash.goel
2014-02-07 12:31 ` Chris Wilson [this message]
2014-02-07 14:34 ` Goel, Akash
2014-03-21 12:35 ` [PATCH 1/2] drm/i915/vlv: Remove the enabling of VS_TIMER_DISPATCH bit in MI MODE reg sourab.gupta
2014-03-21 12:35 ` [PATCH 2/2] drm/i915/vlv: Enabling the TLB invalidate bit in GFX Mode register sourab.gupta
2014-03-21 12:58 ` Chris Wilson
2014-03-21 13:09 ` Gupta, Sourab
2014-03-21 13:17 ` Chris Wilson
2014-03-21 13:31 ` Gupta, Sourab
2014-03-21 13:45 ` Chris Wilson
2014-03-21 15:28 ` [PATCH v2] " sourab.gupta
2014-03-21 16:52 ` Chris Wilson
2014-03-22 4:25 ` Gupta, Sourab
2014-03-22 9:20 ` Chris Wilson
2014-02-07 14:44 ` [PATCH v2 3/3] drm/i915/vlv: Modified the programming of 2 regs in Ring initialisation Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207123128.GJ5360@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.