From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751538AbaBKLZk (ORCPT ); Tue, 11 Feb 2014 06:25:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25336 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbaBKLZg (ORCPT ); Tue, 11 Feb 2014 06:25:36 -0500 Date: Tue, 11 Feb 2014 12:24:55 +0100 From: Jiri Olsa To: Davidlohr Bueso Cc: Don Zickus , acme@ghostprotocols.net, LKML , jmario@redhat.com, fowles@inreach.com, eranian@google.com, Arnaldo Carvalho de Melo , David Ahern , Frederic Weisbecker , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Richard Fowles Subject: Re: [PATCH 01/21] perf c2c: Shared data analyser Message-ID: <20140211112455.GB1124@krava.brq.redhat.com> References: <1392053356-23024-1-git-send-email-dzickus@redhat.com> <1392059886-30812-1-git-send-email-dzickus@redhat.com> <1392070204.25316.1.camel@buesod1.americas.hpqcorp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1392070204.25316.1.camel@buesod1.americas.hpqcorp.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 10, 2014 at 02:10:04PM -0800, Davidlohr Bueso wrote: > On Mon, 2014-02-10 at 14:18 -0500, Don Zickus wrote: > > From: Arnaldo Carvalho de Melo > > > > This is the start of a new perf tool that will collect information about > > memory accesses and analyse it to find things like hot cachelines, etc. > > > > This is basically trying to get a prototype written by Richard Fowles > > written using the tools/perf coding style and libraries. > > > > Start it from 'perf sched', this patch starts the process by adding the > > 'record' subcommand to collect the needed mem loads and stores samples. > > > > It also have the basic 'report' skeleton, resolving the sample address > > and hooking the events found in a perf.data file with methods to handle > > them, right now just printing the resolved perf_sample data structure > > after each event name. > > What tree/branch is this developed against? I'm getting the following > with Linus' latest and tip tree: > > builtin-c2c.c: In function ‘perf_c2c__process_sample’: > builtin-c2c.c:68:20: error: request for member ‘func’ in something not a structure or union > builtin-c2c.c:69:36: error: request for member ‘func’ in something not a structure or union > builtin-c2c.c: In function ‘perf_c2c__read_events’: > builtin-c2c.c:81:2: error: passing argument 1 of ‘perf_session__new’ from incompatible pointer type [-Werror] > In file included from builtin-c2c.c:6:0: > util/session.h:52:22: note: expected ‘struct perf_data_file *’ but argument is of type ‘const char *’ > builtin-c2c.c:81:2: error: too many arguments to function ‘perf_session__new’ > In file included from builtin-c2c.c:6:0: > util/session.h:52:22: note: declared here got the same one.. Don, what did you based on? please, rebase to latest acme's perf/core or send your HEAD ;-) thanks, jirka