From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752071AbaBKQAf (ORCPT <rfc822;w@1wt.eu>);
	Tue, 11 Feb 2014 11:00:35 -0500
Received: from mail-la0-f49.google.com ([209.85.215.49]:60656 "EHLO
	mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751381AbaBKQAa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Feb 2014 11:00:30 -0500
Date: Tue, 11 Feb 2014 17:01:41 +0100
From: Miklos Szeredi <miklos@szeredi.hu>
To: Dave Chinner <david@fromorbit.com>
Cc: viro@ZenIV.linux.org.uk, torvalds@linux-foundation.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        bfields@fieldses.org, hch@infradead.org, akpm@linux-foundation.org,
        dhowells@redhat.com, zab@redhat.com, jack@suse.cz, luto@amacapital.net,
        mszeredi@suse.cz
Subject: Re: [PATCH 00/13] cross rename v4
Message-ID: <20140211160141.GD8204@tucsk.piliscsaba.szeredi.hu>
References: <1391791751-2533-1-git-send-email-miklos@szeredi.hu>
 <20140210105145.GW13997@dastard>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140210105145.GW13997@dastard>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 10, 2014 at 09:51:45PM +1100, Dave Chinner wrote:
> On Fri, Feb 07, 2014 at 05:48:58PM +0100, Miklos Szeredi wrote:
> > Changes since the last version (based on Al's review):
> > 
> >  - cross-rename: fix locking of nondirectories for NFSv4
> >  - ext4: split cross-rename and plain rename into separate functions
> >  - introduce i_op->rename2 with flags, don't touch ->rename
> >  - last (optional) patch to merge ->rename2 back into ->rename
> > 
> > The splitting of the ext4 implemetation was indeed a good idea as it uncovered a
> > memory leak and small inconsistencies with the merged implementation.
> > 
> > Splitting out rename2 will lessen the code churn, but I think is ugly.  However
> > this is a question of taste, last patch can be ommitted without loss of
> > functionality.
> > 
> > Bruce, could you please review the locking and delegation thing in patch #8
> > "vfs: add cross-rename"?
> > 
> > Git tree is here:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git cross-rename
> 
> Miklos, can you please write an xfstest for this new API? That way
> we can verify that the behaviour is as documented, and we can ensure
> that when we implement it on other filesystems it works exactly the
> same on all filesystems?

Splendid idea.  Will do.

Thanks,
Miklos