Re: [PATCH] input synaptics-rmi4: Use put_device() and device_type.release() to free storage.

From: Courtney Cavin <courtney.cavin@sonymobile.com>
To: Christopher Heiny <cheiny@synaptics.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linux Input <linux-input@vger.kernel.org>,
	Andrew Duggan <aduggan@synaptics.com>,
	Vincent Huang <vincent.huang@tw.synaptics.com>,
	Vivian Ly <vly@synaptics.com>,
	Daniel Rosenberg <daniel.rosenberg@synaptics.com>,
	Jean Delvare <khali@linux-fr.org>,
	Joerie de Gram <j.de.gram@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	David Herrmann <dh.herrmann@gmail.com>,
	Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] input synaptics-rmi4: Use put_device() and device_type.release() to free storage.
Date: Tue, 11 Feb 2014 18:49:41 -0800	[thread overview]
Message-ID: <20140212024940.GA1706@sonymobile.com> (raw)
In-Reply-To: <52FAD9D5.5070900@synaptics.com>

On Wed, Feb 12, 2014 at 03:17:57AM +0100, Christopher Heiny wrote:
> On 02/11/2014 05:59 PM, Courtney Cavin wrote:
> > On Wed, Feb 12, 2014 at 12:13:30AM +0100, Christopher Heiny wrote:
> >> For rmi_sensor and rmi_function device_types, use put_device() and
> >> the assocated device_type.release() function to clean up related
> >> structures and storage in the correct and safe order.
> >>
> >> Signed-off-by: Christopher Heiny <cheiny@synaptics.com>
> >> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >> Cc: Linux Walleij <linus.walleij@linaro.org>
> >> Cc: David Herrmann <dh.herrmann@gmail.com>
> >> Cc: Jiri Kosina <jkosina@suse.cz>
> >> Cc: Courtney Cavin <courtney.cavin@sonymobile.com>
> >
> > I'm not a huge fan of you taking my patches, re-formatting them and
> > sending them as your own.  More out of principle then actually caring
> > about ownership.  You at least cc'd me on this one....
> 
> Sorry - no slight was intended at all!  I wasn't sure what the protocol 
> was for picking up an idea from someone else's patch and building on 
> that idea, so I just went with the CC.  I definitely prefer to attribute 
> sources correctly - if you could clarify what should be done (beyond the 
> CC) to acknowledge the author of the original patch, I'd appreciate it.

Sure.  In short, follow Documentation/SubmittingPatches , esp. section
12) Sign your work.

Generally the patch should read something like the following:

 From: Original Author <original.author@example.org>

 *BLURB*

 Signed-off-by: Original Author <original.author@example.org>
 [additional.author@example.org: changed x and y]
 Signed-off-by: Additional Author <additional.author@example.org>

Assuming the original author actually signed-off the patch in the first
place, of course.  The square bracket part is optional, but can be
helpful for reviewers.

I'm somewhat surprised that you are not aware of this procedure, as this
is how Dmitry has replied to some of your patches in the past.

-Courtney