From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDVzq-00013o-Pj for qemu-devel@nongnu.org; Wed, 12 Feb 2014 04:20:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDVzk-0007cs-RK for qemu-devel@nongnu.org; Wed, 12 Feb 2014 04:20:46 -0500 Received: from indium.canonical.com ([91.189.90.7]:37448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDVzk-0007cm-HH for qemu-devel@nongnu.org; Wed, 12 Feb 2014 04:20:40 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.76 #1 (Debian)) id 1WDVzj-0005j5-Q2 for ; Wed, 12 Feb 2014 09:20:39 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id B872E2E80C0 for ; Wed, 12 Feb 2014 09:20:39 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Wed, 12 Feb 2014 09:13:07 -0000 From: dcb <1279257@bugs.launchpad.net> Sender: bounces@canonical.com References: <20140212091307.1972.7704.malonedeb@soybean.canonical.com> Message-Id: <20140212091307.1972.7704.malonedeb@soybean.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false. Reply-To: Bug 1279257 <1279257@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Public bug reported: Source code is } else if ((buf[1] & 4) =3D=3D 1) { Suggest code rework. I found this bug by running static analyser cppcheck over the source code. I also checked the latest code on the web and the bug exists there also. ** Affects: qemu Importance: Undecided Status: New -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1279257 Title: [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) =3D=3D 0x1' is always false. Status in QEMU: New Bug description: Source code is } else if ((buf[1] & 4) =3D=3D 1) { Suggest code rework. I found this bug by running static analyser cppcheck over the source code. I also checked the latest code on the web and the bug exists there also. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1279257/+subscriptions